Jump Script Fix - aka - I believe I can (stop) fly(ing)

User avatar
WolfMerrik
Posts: 199
Joined: Sat Aug 11, 2018 4:59 pm
Location: Maine
Contact:

Re: Jump Script Fix - aka - I believe I can (stop) fly(ing)

Post by WolfMerrik » Sun Sep 02, 2018 1:39 am

Definitely a good idea, I updated the comments in the asm file, and also added a link to this post,
The current version of the file is still HERE
ImageWant to download & share Image NESMaker Resources? Check out My Files on www.NESMakerFiles.com Image
User avatar
cornphillips
Posts: 28
Joined: Wed Aug 15, 2018 5:01 am

Re: Jump Script Fix - aka - I believe I can (stop) fly(ing)

Post by cornphillips » Sun Sep 02, 2018 6:35 am

WolfMerrik wrote:
Sat Sep 01, 2018 5:12 pm
dale_coop wrote:
Sat Sep 01, 2018 4:58 pm
Nice! Will try this script asap.
Thanks WolfMerrik
It is about time I started adding some code to this and got my feet wet with ASM.
It is definitely VERY alien to me, and this was really the first code I wrote for NESMaker

I would definitely appreciate any feedback from you, and you are very welcome!
Hm. Since we probably have a very similar implementation, maybe you can pipe me all your game object settings, since you aren't really observing this?
User avatar
cornphillips
Posts: 28
Joined: Wed Aug 15, 2018 5:01 am

Re: Jump Script Fix - aka - I believe I can (stop) fly(ing)

Post by cornphillips » Sun Sep 02, 2018 6:54 am

WolfMerrik wrote:
Sat Sep 01, 2018 3:38 pm
cornphillips wrote:
Sat Sep 01, 2018 6:47 am
Its a great fix but it doesn't solve my problem, maybe an issue with the collision system.

When I am moving right or left, and falling in the air, when i hit the ground, i appear to hit, then bounce up a pixel for a few frames, then i fall to the ground.
It makes precision platforming much more frustrating to handle.
I had not noticed that in the platformer I was working on, but I will definitely take a look at it, and maybe we can both figure it out.
I know the bounding boxes take into account an extra pixel, so I took one off the bottom of my player object.

Although it sounds like you are indeed having an issue with something in the collision script. Have you tried adjusting the values/speeds of your player object?
It seems like my bug happens no matter what I set my speeds for my player, though I don't have familiarity to adjust the inner workings beyond the jump force in the input script.

It seems to happen when player1 falls to the at least one tile distance, but not when you are jumping up a tile, or when you are jumping onto flat ground.
I also took 1 pixel off the bottom. Maybe adjusting the max gravity speed would help..
Cheers!
User avatar
WolfMerrik
Posts: 199
Joined: Sat Aug 11, 2018 4:59 pm
Location: Maine
Contact:

Re: Jump Script Fix - aka - I believe I can (stop) fly(ing)

Post by WolfMerrik » Sun Sep 02, 2018 1:20 pm

cornphillips wrote:
Sun Sep 02, 2018 6:54 am
It seems to happen when player1 falls to the at least one tile distance, but not when you are jumping up a tile, or when you are jumping onto flat ground.
I also took 1 pixel off the bottom. Maybe adjusting the max gravity speed would help..
Cheers!
Yeah I am definitely experiencing this now, or atleast am noticing it more.
When I had even changed the jump to work via a PRESS, it didnt even fire at times, as there was usually 2-5 frames where I was not technically
on the ground after most landing.... that is NOT good haha.

I am going to try messing with a lot of the settings, I am assuming this MUST be a collision detection issue.
ImageWant to download & share Image NESMaker Resources? Check out My Files on www.NESMakerFiles.com Image
User avatar
WolfMerrik
Posts: 199
Joined: Sat Aug 11, 2018 4:59 pm
Location: Maine
Contact:

Re: Jump Script Fix - aka - I believe I can (stop) fly(ing)

Post by WolfMerrik » Sun Sep 02, 2018 2:11 pm

I tried various adjustments of these values from Constants.asm

Code: Select all

MAX_VSPEED = $6 ;; used for gravity?
GRAVITY_LO = $40
GRAVITY_HI = $0
JUMP_SPEED = #$20
Sadly, with no luck. It may be the code handling the collisions itself, or something else entirely.
ImageWant to download & share Image NESMaker Resources? Check out My Files on www.NESMakerFiles.com Image
User avatar
cornphillips
Posts: 28
Joined: Wed Aug 15, 2018 5:01 am

Re: Jump Script Fix - aka - I believe I can (stop) fly(ing)

Post by cornphillips » Mon Sep 03, 2018 3:22 am

WolfMerrik wrote:
Sun Sep 02, 2018 2:11 pm
I tried various adjustments of these values from Constants.asm

Code: Select all

MAX_VSPEED = $6 ;; used for gravity?
GRAVITY_LO = $40
GRAVITY_HI = $0
JUMP_SPEED = #$20
Sadly, with no luck. It may be the code handling the collisions itself, or something else entirely.
Agreed. Let's bug the devs about it in due time. Lol. Thanks for the deep dive!
User avatar
WolfMerrik
Posts: 199
Joined: Sat Aug 11, 2018 4:59 pm
Location: Maine
Contact:

Re: Jump Script Fix - aka - I believe I can (stop) fly(ing)

Post by WolfMerrik » Mon Sep 03, 2018 4:09 am

As far as I can tell, fixing this is WELL beyond my level of coding in ASM lol
ImageWant to download & share Image NESMaker Resources? Check out My Files on www.NESMakerFiles.com Image
Post Reply