Jump On Hurts (modified jump on kills script)

User avatar
TolerantX
Posts: 63
Joined: Fri Jan 18, 2019 7:58 am

Re: Jump On Hurts (modified jump on kills script)

Post by TolerantX » Mon Jan 13, 2020 5:08 pm

I tried adding this code from the OP in 2 player platformer after IsPlayerLethalInvincible and it didn't account for monster health (which I set to 2).
User avatar
dale_coop
Posts: 5421
Joined: Fri Feb 16, 2018 7:05 am
Location: France

Re: Jump On Hurts (modified jump on kills script)

Post by dale_coop » Mon Jan 13, 2020 10:14 pm

if you made a modification that doesn't work. Please share your modified script. Else there is no way we can tell you where is your error.
-----
Sorry about my poor english
All I need: A Damn Fine Cup of Coffee
My games: PRESS START GAME / UNDERGROUND ADVENTURE / UNDERGROUND ADVENTURE (Arcade version - Byte-Off-2019)
My son's game: KUBO 3
User avatar
TolerantX
Posts: 63
Joined: Fri Jan 18, 2019 7:58 am

Re: Jump On Hurts (modified jump on kills script)

Post by TolerantX » Tue Jan 14, 2020 6:21 am

HandleObjectCollisions_DC.asm
starting at lines 232:

playerWasNotHurtDuringCollision:
;; dale_coop: player in X ?
LDA Object_vulnerability,x
AND #%01000000 ;; is he lethal invincible?
BNE isLethalInvincible
JMP notLethalInvincible
isLethalInvincible:

LDA Object_health,x
SEC
SBC #$01
CMP #$01
BCC +
JMP notMunsterDeath
+
LDX tempxx
LDA Object_x_hi,x
STA temp
LDA Object_y_hi,x
STA temp1
CreateObject temp, temp1, #OBJ_MONSTER_DEATH, #$00, currentNametable ;; create "splat"
LDX tempxx

notMunsterDeath:
;;; ordinarily we'll want to destroy the instance.
DeactivateCurrentObject
;; incrase score, you killed a monster
PlaySound #SND_MONSTER_DEATH




That's what it looks like. It doesn't account for the monster's health it's just an instant kill. Thank you for your help.
User avatar
dale_coop
Posts: 5421
Joined: Fri Feb 16, 2018 7:05 am
Location: France

Re: Jump On Hurts (modified jump on kills script)

Post by dale_coop » Tue Jan 14, 2020 10:47 am

Could you share the entire script? I'll check why it doesn't work in your script.

Small off topic, when you write/copy/paste script on the forum, use the [ code ] tag, around your code. It will make it easier to read (and easier to copy/paste)

Image
-----
Sorry about my poor english
All I need: A Damn Fine Cup of Coffee
My games: PRESS START GAME / UNDERGROUND ADVENTURE / UNDERGROUND ADVENTURE (Arcade version - Byte-Off-2019)
My son's game: KUBO 3
User avatar
TolerantX
Posts: 63
Joined: Fri Jan 18, 2019 7:58 am

Re: Jump On Hurts (modified jump on kills script)

Post by TolerantX » Tue Jan 14, 2020 4:06 pm

Code: Select all

;; LOAD OBJECT 00
;; OUTER LOOP
;; CHECK IF ACTIVE, IF NOT, SKIP OBJECT
;; LOAD self-collision-box
;; START OBJECT COLLISION LOOP
	;; LDA ONE MORE THAN CURRENT OBJECT
	;; CHECK IF ACTIVE.  IF NOT, SKIP THIS other
	;; IF IT IS ACTIVE, then we have to play them against each other.
		;; IS self object hurt by monsters?  If so, and other object is a monster, respond.
		;; IS self object hurt by weapons?  If so, and other object is a weapon, respond.
		;; at this point, we can still gauge whether or not it's affected by player, like with powerups.
		;; ADD one to the object being checked, loop through other objects.
;; increase object, return to outer loop.  Repeat thorugh all self objects.

;; ObjectFlags:
;; 7 - 6 - 5 - 4 - 3 - 2 - 1 - 0
;  |   |   |   |   |   |   |   + -- PERSISTENT (especially good for player!)
;  |   |   |   |   |   |   +------- player type
;  |   |   |   |   |   + ---------- player weapon/projectile type
;  |   |   |   |   +--------------- monster type
;  |   |   |   +------------------- monster weapon/projectile type
;  |   |   +----------------------- pickup / power up
;  |   + -------------------------- target type 
;  +------------------------------- NPC type

;; player type checks monster, mosnter weapon, and pickup.
;; player weapon checks monster and target.
;; nothing else needs checking, as it would all be handled by those two steps.
;; so if it's a monster, do nothing.  if it's a monster projectile, do nothing. 
;; if it's a pickup, or a target, or it ignores all collisions, do nothing.
;; only if it's #%00000110, do something.



HandleObjectCollisions:

	LDA update_screen
	BEQ notChangingScreens
	rts
notChangingScreens:
	
	LDA npc_collision
	AND #%11111110
	STA npc_collision
	LDA npc_collision2
	AND #%11111110
	STA npc_collision2

	;LDA currentBank
	;STA prevBank
	;LDY #BANK_ANIMS
	;JSR bankswitchY
	
	LDX #$00
CollisionOuterLoop:
	TXA
	STA tempx
	LDA Object_status,x
	AND #%10000000
	BNE continueObjectCollisions_objectIsActive
	JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsActive:
	LDA Object_status,x
	AND #%00000100 ;; is ot off screen
	BEQ continueObjectCollisions_objectIsOnScreen
	JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsOnScreen
	LDA Object_status,x
	AND #%00000011
	BEQ continueObjectCollisions_objectIsNotHurtOrInvincible
	JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsNotHurtOrInvincible
	;LDY Object_type,x
	;LDA ObjectFlags,y
	LDA Object_flags,x
	AND #%00000110
	BNE continueObjectCollisions_onlyPlayerTypesCheck
	JMP doneWithThisObjectCollision
continueObjectCollisions_onlyPlayerTypesCheck:
	;; this is either a player or player projectile type of object.
	;; all other types will be taken care of by iterating through these two types.
	;; first, check if it's player type.
	;LdA ObjectFlags,y
	LDA Object_flags,x
	AND #%00000010
	BNE isPlayerTypeForCollision
	JMP notPlayerType_forObjectCollision
isPlayerTypeForCollision:
	;;dale_coop player2
	LDA tempx
	CLC
	CMP player2_object
	BNE +
	STA playerX_object
	;LDA #$01
	;STA tempz
	LDA player2_object
	JMP ++
	+
	STA playerX_object
	;LDA #$00
	;STA tempz
	;dale_coop player2
	LDA player1_object
	++					;;dale_coop player2
	STA colX
	;; is player type for object collision
	;; player's index is loaded into tempx
	JSR GetSelfCollisionBox
	;; now we have the collision box for self object
	;; next we loop through objects.
	
	LDX #$00
LoopThroughOtherObjects_player:
	CPX tempx
	BNE dontSkipThisOtherObject
	JMP skipThisOtherObject ;; other object IS the player, the one doing the counting..
dontSkipThisOtherObject:
	LDA Object_status,x
	AND #%00000100
	BEQ dontSkipThisOtherObject_becauseOnScreen
	JMP skipThisOtherObject ;; because it was off screen.
dontSkipThisOtherObject_becauseOnScreen:

	JSR GetOtherCollisionBox
	

	;; now we can do all the compares
	LDA selfNT_R
	CMP otherNT_L
	BCC + ;; no player object collision
	BNE ++ ;; is still possible to see collision.
	LDA selfRight
	CMP otherLeft
	BCC + ;; no player object collision
++ ;; it is still possible there is a collision here.
	LDA otherNT_R
	CMP selfNT_L
	BCC +
	BNE +++
	LDA otherRight
	CMP selfLeft
	BCC +
	
+++ ;; there was a collision here
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	LDA otherBottom
	CMP selfTop
	BCC +
	LDA selfBottom
	CMP otherTop
	BCC +

	JMP DoPlayerObjectCollision

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;	
+ ;; there is no collision here horizontally.
	JMP noPlayerObjectCollision

DoPlayerObjectCollision:


	
	LDA Object_flags,x
	AND #%10000000 ;; is it an NPC
	BNE isAnNPC
	;; is not an NPC
	JMP isNotAnNPCcollision
isAnNPC:
	;;;; do npc stuff.
	;;;; enables a button to be used to activate a textbox.
	LDA Object_ID,x
	STA textVar
	;LDA gameHandler
	;ORA #%00100000
	;STA gameHandler

	LDA playerX_object
	CMP player2_object
	BEQ +
	;;;; npc collision with player 1:
	LDA npc_collision
	ORA #%00000001
	STA npc_collision
	JMP skipThisOtherObject
	+
	;;;; npc collision with player 2:
	LDA npc_collision2
	ORA #%00000001
	STA npc_collision2
	JMP skipThisOtherObject
	
isNotAnNPCcollision:	
	LDA Object_flags,x
	;LDA ObjectFlags,y
	AND #%00011000 ;; is it a monster type?
	BNE otherIsAMonsterTypeCollision
	JMP otherIsNotAMonsterTypeCollision
otherIsAMonsterTypeCollision:
	LDA Object_status,x
	AND #HURT_STATUS_MASK ;; if the monster is hurt, it can't hurt us
	BEQ yesPlayerObjectCollision
	JMP noPlayerObjectCollision
yesPlayerObjectCollision:
	
	LDA Object_vulnerability,x
	AND #%00000010 ;; in this module, this is ignore player collision
	BEQ doPlayerHurt

	JMP	noPlayerObjectCollision
doPlayerHurt:
	;;;observe health
	TXA
	STA tempxx ;; object is in tempx.
	
	LDX playerX_object
	;;dale_coop player2
	; LDX tempz
	; CPX #$01
	; BNE +
	; LDX player2_object
	; JMP ++
	; +
	;;dale_coop player2
	; LDX player1_object
	; ++					;;dale_coop player2

	LDA Object_status,x
	AND #HURT_STATUS_MASK
	BEQ playerWasNotHurtDuringCollision
	JMP playerWasHurtDuringCollision
playerWasNotHurtDuringCollision:
	;; dale_coop: player in X ?
	LDA Object_vulnerability,x
	AND #%01000000 ;; is he lethal invincible?
	BNE isLethalInvincible
	JMP notLethalInvincible
isLethalInvincible:

LDA Object_health,x
        SEC
        SBC #$01
        CMP #$01
        BCC +
		JMP notMunsterDeath
	+

	LDX tempxx
	LDA Object_x_hi,x
	STA temp
	LDA Object_y_hi,x
	STA temp1
	CreateObject temp, temp1, #OBJ_MONSTER_DEATH, #$00, currentNametable ;; create "splat"
	LDX tempxx
	
	notMunsterDeath:
	
	;;; ordinarily we'll want to destroy the instance.
	 DeactivateCurrentObject
	;; incrase score, you killed a monster
	PlaySound #SND_MONSTER_DEATH
	;TXA
	;STA tempy
	;AddValue #$08, myScore, #$01, #$00

	;;; we also need to set up the routine to update the HUD
	;; for this to work right, health must be a "blank-then-draw" type element.
	;STA hudElementTilesToLoad
	;	LDA #$00
	;	STA hudElementTilesMax
		; LDA DrawHudBytes
		; ora #HUD_myScore
		; STA DrawHudBytes
	;UpdateHud HUD_myScore
	LDX tempxx
	;;
	;; check for monter locks begin:
	CountObjects #%00001000, #$00
	LDA monsterCounter
	CLC
	BEQ +
	JMP ++
	+
		.include SCR_KILLED_LAST_MONSTER
	;; check for monter locks end.
	++	
	JMP skipThisOtherObject
	
notLethalInvincible:

	;;;;;;;;;;;;;;;;;
	;;;;;;;;; WHAT HAPPENS WHEN PLAYER IS HURT
	.include SCR_PLAYER_HURT_SCRIPT
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	
	
playerWasHurtDuringCollision:	
	LDX tempxx
	JMP skipThisOtherObject
otherIsNotAMonsterTypeCollision:
	;LDA ObjectFlags,y
	LDA Object_flags,x
	AND #%00100000 ;; is it a 'collectable'?
	BEQ otherIsNotAcollectable
	;;;; IS A pickup / power up
	DeactivateCurrentObject ;; makes the other object go away
							;; since other object is loaded in X
							
;;=========== WHAT DO YOU WANT TO HAVE HAPPEN WHEN YOU COLLECT THIS ITEM?

	JSR HandlePickupPowerup

	
otherIsNotAcollectable:
noPlayerObjectCollision:	
skipThisOtherObject:
	INX
	CPX #TOTAL_MAX_OBJECTS
	BEQ doneLoopThroughOtherObjects_player
	JMP LoopThroughOtherObjects_player
doneLoopThroughOtherObjects_player:
	;; end of player collision
	LDX tempx ;; restore x
	JMP doneWithThisObjectCollision
	
	
	
notPlayerType_forObjectCollision:
	;; is of player weapon type.
	JSR GetSelfCollisionBox
	;; now we have the collision box for self object
	;; next we loop through objects.
	LDX #$00
LoopThroughOtherObjects_weapon:

	CPX tempx
	BNE dontskipThisOtherObject_weapon
	JMP skipThisOtherObject_weapon
dontskipThisOtherObject_weapon
	JSR GetOtherCollisionBox
	;; now we can do all the compares
	LDA selfNT_R
	CMP otherNT_L
	BCC + ;; no player object collision
	BNE ++ ;; is still possible to see collision.
	LDA selfRight
	CMP otherLeft
	BCC + ;; no player object collision
++ ;; it is still possible there is a collision here.
	LDA otherNT_R
	CMP selfNT_L
	BCC +
	BNE +++
	LDA otherRight
	CMP selfLeft
	BCC +
	
+++ ;; there was a collision here
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	LDA otherBottom
	CMP selfTop
	BCC +
	LDA selfBottom
	CMP otherTop
	BCC +

	JMP doWeaponObjectCollision

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;	
+ ;; there is no collision here horizontally.
	JMP noWeaponObjectCollision
doWeaponObjectCollision:
	;; go through the different types of collision possible.
	;; first, check monster OR monser projectile, as that should lead to hurt/death
	;LDY Object_type,x
	;LDA ObjectFlags,y
	LDA Object_flags,x
	AND #%00001000 ;; is it a monster type?
	;;; if you'd like the player weapon to ALSO destroy projectiles
	;;; use #%00011000 here
	BNE otherIsMonsterTypeCollision_weapon
	JMP otherIsNotAMonsterTypeCollision_weapon
otherIsMonsterTypeCollision_weapon:
;;;;;;;;;;;;;;;;;;;;;;;;
	TXA
	PHA
	.include SCR_HANDLE_HURT_MONSTER
	PLA
	TAX
	;;; if monster dies, count monsters
	;; right now, he always dies, so count the monsters.
	;;JSR countAllMonsters	
	

	
otherIsNotAMonsterTypeCollision_weapon:
	
noWeaponObjectCollision:	
skipThisOtherObject_weapon:
	INX
	CPX #TOTAL_MAX_OBJECTS
	BEQ doneWithLoopingThroughWeaponObjects
	JMP LoopThroughOtherObjects_weapon
doneWithLoopingThroughWeaponObjects:
	
	
	
	;; end of player collision
	LDX tempx ;; restore x
	JMP doneWithThisObjectCollision
	
	
	
	
doneWithThisObjectCollision:
	LDX tempx
	INX
	CPX #TOTAL_MAX_OBJECTS
	BEQ doneWithAllObjects
	JMP CollisionOuterLoop
doneWithAllObjects:
	;;;;;;;;;;;;;;;;;;;;;;;;;
	;; for this module
	;; we will check for the melee position.
	;; but rather than waste space with an entire object
	;; we'll just test it against a single point
	.include SCR_CHECK_SPRITE_WEAPON

	RTS
	
	
	
	
	
	
GetSelfCollisionBox:	
	LDA Object_x_hi,x
	CLC
	ADC Object_left,x
	STA selfLeft

	LDA Object_x_hi,x
	CLC
	ADC Object_right,x
	STA selfRight

	LDA Object_y_hi,x
	CLC
	ADC Object_top,x
	STA selfTop
	
	LDA Object_y_hi,x
	CLC
	ADC Object_bottom,x
	STA selfBottom
	LDA Object_x_hi,x
	CLC
	ADC Object_origin_x,x
	STA selfCenterX
	LDA Object_y_hi,x
	CLC
	ADC Object_origin_y,x
	STA selfCenterY
	

	RTS
	
GetOtherCollisionBox:
	LDA Object_x_hi,x
	CLC
	ADC Object_left,x
	STA otherLeft

	LDA Object_x_hi,x
	CLC
	ADC Object_right,x
	STA otherRight


	LDA Object_y_hi,x
	CLC
	ADC Object_top,x

	STA otherTop
	LDA Object_y_hi,x
	CLC
	ADC Object_bottom,x
	STA otherBottom
	LDA Object_x_hi,x
	CLC
	ADC Object_origin_x,x
	STA otherCenterX
	LDA Object_y_hi,x
	CLC
	ADC Object_origin_y,x
	STA otherCenterY
	

	RTS
	
	
	
	
	
	
	
DetermineRecoilDirection:

	;;;RECOIL
	;;First check for the abs x value
	LDA recoil_selfX
	SEC
	SBC recoil_otherX
	BCS absCheckDone
	EOR #$FF
	CLC
	ADC #$01
absCheckDone:
	STA temp
	LDA recoil_selfY
	SEC
	SBC recoil_otherY
	BCS absCheckDone2
	EOR #$FF
	CLC
	ADC #$01
absCheckDone2:
	CMP temp
	BCS vCol
	LDA recoil_selfX
	CMP recoil_otherX
	BCS recoilRight
	;; recoil left
	;LDX #$01
	LDA #RECOIL_SPEED_LO
	STA Object_h_speed_lo,x
	LDA #$00
	SEC
	SBC	#RECOIL_SPEED_HI
	STA Object_h_speed_hi,x
	LDA #$00
	STA Object_v_speed_hi,x
	STA Object_v_speed_lo,x
	LDA #%10000000
	STA temp1
	LDA Object_movement,x
	AND #%00000111
	ORA temp1
	STA Object_movement,x
	RTS
	
recoilRight:
	;LDX #$01
	LDA #RECOIL_SPEED_LO
	STA Object_h_speed_lo,x
	LDA	#RECOIL_SPEED_HI
	STA Object_h_speed_hi,x
	LDA #$00
	STA Object_v_speed_hi,x
	STA Object_v_speed_lo,x
	LDA #%11000000
	STA temp1
	LDA Object_movement,x
	AND #%00000111
	ORA temp1
	STA Object_movement,x
	RTS
	
vCol:
	LDA recoil_selfY
	CMP recoil_otherY
	BCS recoilDown
	;LDX #$01
	LDA #RECOIL_SPEED_LO
	STA Object_v_speed_lo,x
	LDA #$00
	SEC
	SBC	#RECOIL_SPEED_HI
	STA Object_v_speed_hi,x
	LDA #%00100000
	STA temp1
	LDA #$00
	STA Object_h_speed_hi,x
	STA Object_h_speed_lo,x
	LDA Object_movement,x
	AND #%00000111
	ORA temp1
	STA Object_movement,x

	RTS
	
recoilDown:
	;LDX #$01
	LDA #RECOIL_SPEED_LO
	STA Object_v_speed_lo,x
	LDA #RECOIL_SPEED_HI
	STA Object_v_speed_hi,x
	LDA #%00110000
	STA temp1
	LDA #$00
	STA Object_h_speed_hi,x
	STA Object_h_speed_lo,x
	LDA Object_movement,x
	AND #%00000111
	ORA temp1
	STA Object_movement,x
	
	RTS
	[code]
User avatar
dale_coop
Posts: 5421
Joined: Fri Feb 16, 2018 7:05 am
Location: France

Re: Jump On Hurts (modified jump on kills script)

Post by dale_coop » Tue Jan 14, 2020 4:25 pm

But this one is not the "HandleObjectCollisions withJumpOnKills" asm script... as the original post of this topic.
Yours it the normal HandleObjectCollisions the one where you CAN NOT jump on monsters (not implemented in that script).

Try assigning the HandleObjectCollisions_DCwithJumpOnKills.asm script (in the "ModuleScripts\MainScripts\SimplePlatformer" folder) to the "Handle Object Collisions" element in your "Project Settings > Script Settings", and try again the modification...
if yoru modification doesn't work, share again your new modified script. I'll take a look.
-----
Sorry about my poor english
All I need: A Damn Fine Cup of Coffee
My games: PRESS START GAME / UNDERGROUND ADVENTURE / UNDERGROUND ADVENTURE (Arcade version - Byte-Off-2019)
My son's game: KUBO 3
User avatar
Winterbeast3
Posts: 8
Joined: Tue Jan 28, 2020 12:13 am
Location: York, PA

Re: Jump On Hurts (modified jump on kills script)

Post by Winterbeast3 » Sat Feb 01, 2020 4:26 pm

I followed this post before it got into 2player. However It works great but the only problem I have is the HUD. Every time I jump on the monster the HUD is showing health damage however I'm not really taking damage. It can go to 1 health but when I walk into another enemy and take real damage it shows the true value and subtracts like normal. Is there a simple fix for this? Sorry I'm new to this forum and am going to attempt to attach the entire script.

Code: Select all

;; LOAD OBJECT 00
;; OUTER LOOP
;; CHECK IF ACTIVE, IF NOT, SKIP OBJECT
;; LOAD self-collision-box
;; START OBJECT COLLISION LOOP
    ;; LDA ONE MORE THAN CURRENT OBJECT
    ;; CHECK IF ACTIVE.  IF NOT, SKIP THIS other
    ;; IF IT IS ACTIVE, then we have to play them against each other.
        ;; IS self object hurt by monsters?  If so, and other object is a monster, respond.
        ;; IS self object hurt by weapons?  If so, and other object is a weapon, respond.
        ;; at this point, we can still gauge whether or not it's affected by player, like with powerups.
        ;; ADD one to the object being checked, loop through other objects.
;; increase object, return to outer loop.  Repeat thorugh all self objects.

;; ObjectFlags:
;; 7 - 6 - 5 - 4 - 3 - 2 - 1 - 0
;  |   |   |   |   |   |   |   + -- PERSISTENT (especially good for player!)
;  |   |   |   |   |   |   +------- player type
;  |   |   |   |   |   + ---------- player weapon/projectile type
;  |   |   |   |   +--------------- monster type
;  |   |   |   +------------------- monster weapon/projectile type
;  |   |   +----------------------- pickup / power up
;  |   + -------------------------- target type 
;  +------------------------------- NPC type

;; player type checks monster, mosnter weapon, and pickup.
;; player weapon checks monster and target.
;; nothing else needs checking, as it would all be handled by those two steps.
;; so if it's a monster, do nothing.  if it's a monster projectile, do nothing. 
;; if it's a pickup, or a target, or it ignores all collisions, do nothing.
;; only if it's #%00000110, do something.



HandleObjectCollisions:

    LDA update_screen
    BEQ notChangingScreens
    rts
notChangingScreens:
    
    LDA npc_collision
    AND #%11111110
    STA npc_collision

    ;LDA currentBank
    ;STA prevBank
    ;LDY #BANK_ANIMS
    ;JSR bankswitchY
    
    LDX #$00
CollisionOuterLoop:
    TXA
    STA tempx
    LDA Object_status,x
    AND #%10000000
    BNE continueObjectCollisions_objectIsActive
    JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsActive:
    LDA Object_status,x
    AND #%00000100 ;; is ot off screen
    BEQ continueObjectCollisions_objectIsOnScreen
    JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsOnScreen
    LDA Object_status,x
    AND #%00000011
    BEQ continueObjectCollisions_objectIsNotHurtOrInvincible
    JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsNotHurtOrInvincible
    ;LDY Object_type,x
    ;LDA ObjectFlags,y
    LDA Object_flags,x
    AND #%00000110
    BNE continueObjectCollisions_onlyPlayerTypesCheck
    JMP doneWithThisObjectCollision
continueObjectCollisions_onlyPlayerTypesCheck:
    ;; this is either a player or player projectile type of object.
    ;; all other types will be taken care of by iterating through these two types.
    ;; first, check if it's player type.
    ;LdA ObjectFlags,y
    LDA Object_flags,x
    AND #%00000010
    BNE isPlayerTypeForCollision
    JMP notPlayerType_forObjectCollision
isPlayerTypeForCollision:
    LDA player1_object
    STA colX
    ;; is player type for object collision
    ;; player's index is loaded into tempx
    JSR GetSelfCollisionBox
    ;; now we have the collision box for self object
    ;; next we loop through objects.
    
    LDX #$00
LoopThroughOtherObjects_player:
    CPX tempx
    BNE dontSkipThisOtherObject
    JMP skipThisOtherObject ;; other object IS the player, the one doing the counting..
dontSkipThisOtherObject:
    LDA Object_status,x
    AND #%00000100
    BEQ dontSkipThisOtherObject_becauseOnScreen
    JMP skipThisOtherObject ;; because it was off screen.
dontSkipThisOtherObject_becauseOnScreen:

    JSR GetOtherCollisionBox
    

    ;; now we can do all the compares
    LDA selfNT_R
    CMP otherNT_L
    BCC + ;; no player object collision
    BNE ++ ;; is still possible to see collision.
    LDA selfRight
    CMP otherLeft
    BCC + ;; no player object collision
++ ;; it is still possible there is a collision here.
    LDA otherNT_R
    CMP selfNT_L
    BCC +
    BNE +++
    LDA otherRight
    CMP selfLeft
    BCC +
    
+++ ;; there was a collision here
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
    LDA otherBottom
    CMP selfTop
    BCC +
    LDA selfBottom
    CMP otherTop
    BCC +

    JMP DoPlayerObjectCollision

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;    
+ ;; there is no collision here horizontally.
    JMP noPlayerObjectCollision

DoPlayerObjectCollision:


    
    LDA Object_flags,x
    AND #%10000000 ;; is it an NPC
    BNE isAnNPC
    ;; is not an NPC
    JMP isNotAnNPCcollision
isAnNPC:
    ;;;; do npc stuff.
    LDA npc_collision
    ORA #%00000001
    STA npc_collision
    ;;;; enables a button to be used to activate a textbox.
    LDA Object_ID,x
    STA textVar
    ;LDA gameHandler
    ;ORA #%00100000
    ;STA gameHandler

    JMP skipThisOtherObject
    
isNotAnNPCcollision:    
    LDA Object_flags,x
    ;LDA ObjectFlags,y
    AND #%00011000 ;; is it a monster type?
    BNE otherIsAMonsterTypeCollision
    JMP otherIsNotAMonsterTypeCollision
otherIsAMonsterTypeCollision:
    LDA Object_status,x
    AND #HURT_STATUS_MASK ;; if the monster is hurt, it can't hurt us
    BEQ yesPlayerObjectCollision
    JMP noPlayerObjectCollision
yesPlayerObjectCollision:
    
    LDA Object_vulnerability,x
    AND #%00000010 ;; in this module, this is ignore player collision
    BEQ doPlayerHurt
    JMP noPlayerObjectCollision
doPlayerHurt:
    ;;;observe health
    TXA
    STA tempx ;; object is in tempx.
    LDX player1_object
    LDA Object_status,x
    AND #HURT_STATUS_MASK
    BEQ playerWasNotHurtDuringCollision
    JMP playerWasHurtDuringCollision
playerWasNotHurtDuringCollision:
;;---- Jump On Kills code begin ----
    TYA
    STA tempy
    LDX tempx
    LDA Object_vulnerability,x
    AND #%00010000
    BNE jumpOnMonster
    LDX player1_object
    JMP dontJumpOnMonster
jumpOnMonster:
    LDX player1_object
    ;TXA
    ;STA tempx
    ;JMP playerWasHurtDuringCollision
    ;LDX player1_object
    LDA selfBottom
    CMP otherCenterY
 BCC +
  JMP dontJumpOnMonster
  +
    ;;; JUMP ON MONSTER
    LDX player1_object
    LDA #$00
    SEC
    SBC #$04
    STA Object_v_speed_hi,x
    LDX tempx
    LDA Object_health,x
        SEC
        SBC #$01
        CMP #$01
        BCC +
        JMP notJumpOnMonsterDeath
    +
    DeactivateCurrentObject
    PlaySound #SND_SPLAT
    
    LDY tempy
    ;; INCREASE SCORE
    AddValue #$08, myScore, #$01, #$02
    UpdateHud HUD_myScore   
    JMP playerWasHurtDuringCollision ;; just skips collision
    
dontJumpOnMonster:
notJumpOnMonsterDeath:
;;---- Jump On Kills code end ----

    LDA Object_vulnerability,x
    AND #%01000000 ;; is he lethal invincible?
    BNE isLethalInvincible
    JMP notLethalInvincible
isLethalInvincible:
    LDX tempx
    LDA Object_x_hi,x
    STA temp
    LDA Object_y_hi,x
    STA temp1
    CreateObject temp, temp1, #OBJ_MONSTER_DEATH, #$00, currentNametable ;; create "splat"
    LDX tempx
    
    ;;; ordinarily we'll want to destroy the instance.
     DeactivateCurrentObject
    ;; incrase score, you killed a monster
    PlaySound #SND_SPLAT
    TXA
    STA tempx
    AddValue #$08, myScore, #$01, #$00

    ;;; we also need to set up the routine to update the HUD
    ;; for this to work right, health must be a "blank-then-draw" type element.
    ; STA hudElementTilesToLoad
    ; LDA #$00
       ;STA hudElementTilesMax
     ;LDA DrawHudBytes
         ;ora #HUD_myScore
         ;STA DrawHudBytes
    UpdateHud HUD_myScore
    LDX tempx
    ;;
    
    JMP skipThisOtherObject
    
notLethalInvincible:
    
    ;;;;;;;;;;;;;;;;;
    ;;;;;;;;; WHAT HAPPENS WHEN PLAYER IS HURT
    .include SCR_PLAYER_HURT_SCRIPT
    ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
    ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
    
    
playerWasHurtDuringCollision:   
    LDX tempx
    JMP skipThisOtherObject
otherIsNotAMonsterTypeCollision:
    ;LDA ObjectFlags,y
    LDA Object_flags,x
    AND #%00100000 ;; is it a 'collectable'?
    BEQ otherIsNotAcollectable
    ;;;; IS A pickup / power up
    DeactivateCurrentObject ;; makes the other object go away
                            ;; since other object is loaded in X
                            
;;=========== WHAT DO YOU WANT TO HAVE HAPPEN WHEN YOU COLLECT THIS ITEM?

    JSR HandlePickupPowerup

    
otherIsNotAcollectable:
noPlayerObjectCollision:    
skipThisOtherObject:
    INX
    CPX #TOTAL_MAX_OBJECTS
    BEQ doneLoopThroughOtherObjects_player
    JMP LoopThroughOtherObjects_player
doneLoopThroughOtherObjects_player:
    ;; end of player collision
    LDX tempx ;; restore x
    JMP doneWithThisObjectCollision
    
    
    
notPlayerType_forObjectCollision:
    ;; is of player weapon type.
    JSR GetSelfCollisionBox
    ;; now we have the collision box for self object
    ;; next we loop through objects.
    LDX #$00
LoopThroughOtherObjects_weapon:

    CPX tempx
    BNE dontskipThisOtherObject_weapon
    JMP skipThisOtherObject_weapon
dontskipThisOtherObject_weapon
    JSR GetOtherCollisionBox
    ;; now we can do all the compares
    LDA selfNT_R
    CMP otherNT_L
    BCC + ;; no player object collision
    BNE ++ ;; is still possible to see collision.
    LDA selfRight
    CMP otherLeft
    BCC + ;; no player object collision
++ ;; it is still possible there is a collision here.
    LDA otherNT_R
    CMP selfNT_L
    BCC +
    BNE +++
    LDA otherRight
    CMP selfLeft
    BCC +
    
+++ ;; there was a collision here
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
    LDA otherBottom
    CMP selfTop
    BCC +
    LDA selfBottom
    CMP otherTop
    BCC +

    JMP doWeaponObjectCollision

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;    
+ ;; there is no collision here horizontally.
    JMP noWeaponObjectCollision
doWeaponObjectCollision:
    ;; go through the different types of collision possible.
    ;; first, check monster OR monser projectile, as that should lead to hurt/death
    ;LDY Object_type,x
    ;LDA ObjectFlags,y
    LDA Object_flags,x
    AND #%00001000 ;; is it a monster type?
    ;;; if you'd like the player weapon to ALSO destroy projectiles
    ;;; use #%00011000 here
    BNE otherIsMonsterTypeCollision_weapon
    JMP otherIsNotAMonsterTypeCollision_weapon
otherIsMonsterTypeCollision_weapon:
;;;;;;;;;;;;;;;;;;;;;;;;
    TXA
    PHA
    .include SCR_HANDLE_HURT_MONSTER
    PLA
    TAX
    ;;; if monster dies, count monsters
    ;; right now, he always dies, so count the monsters.
    JSR countAllMonsters    
    

    
otherIsNotAMonsterTypeCollision_weapon:
    
noWeaponObjectCollision:    
skipThisOtherObject_weapon:
    INX
    CPX #TOTAL_MAX_OBJECTS
    BEQ doneWithLoopingThroughWeaponObjects
    JMP LoopThroughOtherObjects_weapon
doneWithLoopingThroughWeaponObjects:
    
    
    
    ;; end of player collision
    LDX tempx ;; restore x
    JMP doneWithThisObjectCollision
    
    
    
    
doneWithThisObjectCollision:
    LDX tempx
    INX
    CPX #TOTAL_MAX_OBJECTS
    BEQ doneWithAllObjects
    JMP CollisionOuterLoop
doneWithAllObjects:
    ;;;;;;;;;;;;;;;;;;;;;;;;;
    ;; for this module
    ;; we will check for the melee position.
    ;; but rather than waste space with an entire object
    ;; we'll just test it against a single point
    .include SCR_CHECK_SPRITE_WEAPON

    RTS
    
    
    
    
    
    
GetSelfCollisionBox:    
    LDA Object_x_hi,x
    CLC
    ADC Object_left,x
    STA selfLeft
    LDA Object_scroll,x
    ADC #$00
    STA selfNT_L
    
    LDA Object_x_hi,x
    CLC
    ADC Object_right,x
    STA selfRight
    LDA Object_scroll,x
    ADC #$00
    STA selfNT_R
    
    LDA Object_vulnerability,x
    AND #%10000000
    BEQ noDuckingBit
    LDA Object_bottom
    SEC 
    SBC Object_top
    STA temp
    LDA Object_y_hi,x
    CLC
    ADC temp
    JMP gotSelfTop
noDuckingBit:
    LDA Object_y_hi,x
    CLC
    ADC Object_top,x
gotSelfTop:
    STA selfTop
    LDA Object_y_hi,x
    CLC
    ADC Object_bottom,x
    STA selfBottom
    LDA Object_x_hi,x
    CLC
    ADC Object_origin_x,x
    STA selfCenterX
    LDA Object_y_hi,x
    CLC
    ADC Object_origin_y,x
    STA selfCenterY
    

    RTS
    
GetOtherCollisionBox:
    LDA Object_x_hi,x
    CLC
    ADC Object_left,x
    STA otherLeft
    LDA Object_scroll,x
    ADC #$00
    STA otherNT_L
    
    LDA Object_x_hi,x
    CLC
    ADC Object_right,x
    STA otherRight
    LDA Object_scroll,x
    ADC #$00
    STA otherNT_R
    
    LDA Object_vulnerability,x
    AND #%10000000
    BEQ noDuckingBit_other
    LDA Object_bottom
    SEC 
    SBC Object_top
    STA temp
    LDA Object_y_hi,x
    CLC
    ADC temp
    JMP gotSelfTop_other
noDuckingBit_other:
    LDA Object_y_hi,x
    CLC
    ADC Object_top,x
gotSelfTop_other:   
    
    STA otherTop
    LDA Object_y_hi,x
    CLC
    ADC Object_bottom,x
    STA otherBottom
    LDA Object_x_hi,x
    CLC
    ADC Object_origin_x,x
    STA otherCenterX
    LDA Object_y_hi,x
    CLC
    ADC Object_origin_y,x
    STA otherCenterY
    

    RTS
    
    
    
    
    
    
    
DetermineRecoilDirection:

    ;;;RECOIL
    ;;First check for the abs x value
    LDA recoil_selfX
    SEC
    SBC recoil_otherX
    BCS absCheckDone
    EOR #$FF
    CLC
    ADC #$01
absCheckDone:
    STA temp
    LDA recoil_selfY
    SEC
    SBC recoil_otherY
    BCS absCheckDone2
    EOR #$FF
    CLC
    ADC #$01
absCheckDone2:
    CMP temp
    BCS vCol
    LDA recoil_selfX
    CMP recoil_otherX
    BCS recoilRight
    ;; recoil left
    ;LDX #$01
    LDA #RECOIL_SPEED_LO
    STA Object_h_speed_lo,x
    LDA #$00
    SEC
    SBC #RECOIL_SPEED_HI
    STA Object_h_speed_hi,x
    LDA #$00
    STA Object_v_speed_hi,x
    STA Object_v_speed_lo,x
    LDA #%10000000
    STA temp1
    LDA Object_movement,x
    AND #%00000111
    ORA temp1
    STA Object_movement,x
    CPX player1_object
    BNE dontChangeScrollDirectionL
    LDA #$00
    STA scrollDirection
dontChangeScrollDirectionL
    RTS
    
recoilRight:
    ;LDX #$01
    LDA #RECOIL_SPEED_LO
    STA Object_h_speed_lo,x
    LDA #RECOIL_SPEED_HI
    STA Object_h_speed_hi,x
    LDA #$00
    STA Object_v_speed_hi,x
    STA Object_v_speed_lo,x
    LDA #%11000000
    STA temp1
    LDA Object_movement,x
    AND #%00000111
    ORA temp1
    STA Object_movement,x
    CPX player1_object
    BNE dontChangeScrollDirectionR
    LDA #$01
    STA scrollDirection
dontChangeScrollDirectionR:
    RTS
    
vCol:
    LDA recoil_selfY
    CMP recoil_otherY
    BCS recoilDown
    ;LDX #$01
    LDA #RECOIL_SPEED_LO
    STA Object_v_speed_lo,x
    LDA #$00
    SEC
    SBC #RECOIL_SPEED_HI
    STA Object_v_speed_hi,x
    LDA #%00100000
    STA temp1
    LDA #$00
    STA Object_h_speed_hi,x
    STA Object_h_speed_lo,x
    LDA Object_movement,x
    AND #%00000111
    ORA temp1
    STA Object_movement,x

    RTS
    
recoilDown:
    ;LDX #$01
    LDA #RECOIL_SPEED_LO
    STA Object_v_speed_lo,x
    LDA #RECOIL_SPEED_HI
    STA Object_v_speed_hi,x
    LDA #%00110000
    STA temp1
    LDA #$00
    STA Object_h_speed_hi,x
    STA Object_h_speed_lo,x
    LDA Object_movement,x
    AND #%00000111
    ORA temp1
    STA Object_movement,x
    
    RTS
User avatar
dale_coop
Posts: 5421
Joined: Fri Feb 16, 2018 7:05 am
Location: France

Re: Jump On Hurts (modified jump on kills script)

Post by dale_coop » Sun Feb 02, 2020 11:01 am

Winterbeast3 wrote:
Sat Feb 01, 2020 4:26 pm
I followed this post before it got into 2player. However It works great but the only problem I have is the HUD. Every time I jump on the monster the HUD is showing health damage however I'm not really taking damage. It can go to 1 health but when I walk into another enemy and take real damage it shows the true value and subtracts like normal. Is there a simple fix for this? Sorry I'm new to this forum and am going to attempt to attach the entire script.
Try this script instead:

Code: Select all

;; LOAD OBJECT 00
;; OUTER LOOP
;; CHECK IF ACTIVE, IF NOT, SKIP OBJECT
;; LOAD self-collision-box
;; START OBJECT COLLISION LOOP
	;; LDA ONE MORE THAN CURRENT OBJECT
	;; CHECK IF ACTIVE.  IF NOT, SKIP THIS other
	;; IF IT IS ACTIVE, then we have to play them against each other.
		;; IS self object hurt by monsters?  If so, and other object is a monster, respond.
		;; IS self object hurt by weapons?  If so, and other object is a weapon, respond.
		;; at this point, we can still gauge whether or not it's affected by player, like with powerups.
		;; ADD one to the object being checked, loop through other objects.
;; increase object, return to outer loop.  Repeat thorugh all self objects.

;; ObjectFlags:
;; 7 - 6 - 5 - 4 - 3 - 2 - 1 - 0
;  |   |   |   |   |   |   |   + -- PERSISTENT (especially good for player!)
;  |   |   |   |   |   |   +------- player type
;  |   |   |   |   |   + ---------- player weapon/projectile type
;  |   |   |   |   +--------------- monster type
;  |   |   |   +------------------- monster weapon/projectile type
;  |   |   +----------------------- pickup / power up
;  |   + -------------------------- target type 
;  +------------------------------- NPC type

;; player type checks monster, mosnter weapon, and pickup.
;; player weapon checks monster and target.
;; nothing else needs checking, as it would all be handled by those two steps.
;; so if it's a monster, do nothing.  if it's a monster projectile, do nothing. 
;; if it's a pickup, or a target, or it ignores all collisions, do nothing.
;; only if it's #%00000110, do something.



HandleObjectCollisions:

	LDA update_screen
	BEQ notChangingScreens
	rts
notChangingScreens:
	
	LDA npc_collision
	AND #%11111110
	STA npc_collision

	;LDA currentBank
	;STA prevBank
	;LDY #BANK_ANIMS
	;JSR bankswitchY
	
	LDX #$00
CollisionOuterLoop:
	TXA
	STA tempx
	LDA Object_status,x
	AND #%10000000
	BNE continueObjectCollisions_objectIsActive
	JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsActive:
	LDA Object_status,x
	AND #%00000100 ;; is ot off screen
	BEQ continueObjectCollisions_objectIsOnScreen
	JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsOnScreen
	LDA Object_status,x
	AND #%00000011
	BEQ continueObjectCollisions_objectIsNotHurtOrInvincible
	JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsNotHurtOrInvincible
	;LDY Object_type,x
	;LDA ObjectFlags,y
	LDA Object_flags,x
	AND #%00000110
	BNE continueObjectCollisions_onlyPlayerTypesCheck
	JMP doneWithThisObjectCollision
continueObjectCollisions_onlyPlayerTypesCheck:
	;; this is either a player or player projectile type of object.
	;; all other types will be taken care of by iterating through these two types.
	;; first, check if it's player type.
	;LdA ObjectFlags,y
	LDA Object_flags,x
	AND #%00000010
	BNE isPlayerTypeForCollision
	JMP notPlayerType_forObjectCollision
isPlayerTypeForCollision:
	LDA player1_object
	STA colX
	;; is player type for object collision
	;; player's index is loaded into tempx
	JSR GetSelfCollisionBox
	;; now we have the collision box for self object
	;; next we loop through objects.
	
	LDX #$00
LoopThroughOtherObjects_player:
	CPX tempx
	BNE dontSkipThisOtherObject
	JMP skipThisOtherObject ;; other object IS the player, the one doing the counting..
dontSkipThisOtherObject:
	LDA Object_status,x
	AND #%00000100
	BEQ dontSkipThisOtherObject_becauseOnScreen
	JMP skipThisOtherObject ;; because it was off screen.
dontSkipThisOtherObject_becauseOnScreen:

	JSR GetOtherCollisionBox
	

	;; now we can do all the compares
	LDA selfNT_R
	CMP otherNT_L
	BCC + ;; no player object collision
	BNE ++ ;; is still possible to see collision.
	LDA selfRight
	CMP otherLeft
	BCC + ;; no player object collision
++ ;; it is still possible there is a collision here.
	LDA otherNT_R
	CMP selfNT_L
	BCC +
	BNE +++
	LDA otherRight
	CMP selfLeft
	BCC +
	
+++ ;; there was a collision here
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	LDA otherBottom
	CMP selfTop
	BCC +
	LDA selfBottom
	CMP otherTop
	BCC +

	JMP DoPlayerObjectCollision

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;	
+ ;; there is no collision here horizontally.
	JMP noPlayerObjectCollision

DoPlayerObjectCollision:


	
	LDA Object_flags,x
	AND #%10000000 ;; is it an NPC
	BNE isAnNPC
	;; is not an NPC
	JMP isNotAnNPCcollision
isAnNPC:
	;;;; do npc stuff.
	LDA npc_collision
	ORA #%00000001
	STA npc_collision
	;;;; enables a button to be used to activate a textbox.
	LDA Object_ID,x
	STA textVar
	;LDA gameHandler
	;ORA #%00100000
	;STA gameHandler

	JMP skipThisOtherObject
	
isNotAnNPCcollision:	
	LDA Object_flags,x
	;LDA ObjectFlags,y
	AND #%00011000 ;; is it a monster type?
	BNE otherIsAMonsterTypeCollision
	JMP otherIsNotAMonsterTypeCollision
otherIsAMonsterTypeCollision:
	LDA Object_status,x
	AND #HURT_STATUS_MASK ;; if the monster is hurt, it can't hurt us
	BEQ yesPlayerObjectCollision
	JMP noPlayerObjectCollision
yesPlayerObjectCollision:
	
	LDA Object_vulnerability,x
	AND #%00000010 ;; in this module, this is ignore player collision
	BEQ doPlayerHurt
	JMP	noPlayerObjectCollision
doPlayerHurt:
	;;;observe health
	TXA
	STA tempx ;; object is in tempx.
	LDX player1_object
	LDA Object_status,x
	AND #HURT_STATUS_MASK
	BEQ playerWasNotHurtDuringCollision
	JMP playerWasHurtDuringCollision
playerWasNotHurtDuringCollision:
;;---- Jump On Kills code begin ----
	TYA
	STA tempy
	LDX tempx
	LDA Object_vulnerability,x
	AND #%00010000
	BNE jumpOnMonster
	LDX player1_object
	JMP dontJumpOnMonster
jumpOnMonster:
	LDX player1_object
	LDA selfBottom
	CMP otherCenterY
	BCC +
	JMP dontJumpOnMonster
	+
	;;; JUMP ON MONSTER
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	LDA #$00
	SEC
	SBC #$04
	STA Object_v_speed_hi,x
	
	LDX tempx

        LDA Object_status,x
        AND #HURT_STATUS_MASK
        BEQ dontskipHurtingMonsterJumpOnMonster
        JMP skipHurtingMonsterJumpOnMonster
    dontskipHurtingMonsterJumpOnMonster:
        LDA Object_status,x
        ORA #%00000001
        STA Object_status,x
        LDA #HURT_TIMER
        STA Object_timer_0,x
        ;;; assume idle is in step 0
        ChangeObjectState #$00,#$02
        ;;;; unfortunately this recoil is backwards
        LDA Object_status,x
        AND #%00000100
        BNE skipRecoilBecauseOnEdgeJumpOnMonster
        LDA Object_vulnerability,x
        AND #%00001000 
        BNE skipRecoilBecauseOnEdgeJumpOnMonster ;; skip recoil because bit is flipped to ignore recoil
        
        LDA selfCenterX
        STA recoil_otherX
        LDA selfCenterY
        STA recoil_otherY
        LDA otherCenterX
        STA recoil_selfX
        LDA otherCenterY
        STA recoil_selfY
        JSR DetermineRecoilDirection
    skipRecoilBecauseOnEdgeJumpOnMonster:
        LDA Object_health,x
        SEC
        SBC #$01
        CMP #$01
        BCC +
		JMP notMonsterDeathJumpOnMonster
	+

		LDA Object_x_hi,x
		STA temp
		LDA Object_y_hi,x
		STA temp1
		LDA Object_scroll,x
		STA temp2

        DeactivateCurrentObject
        PlaySound #SND_SPLAT
    
		STX tempy	;;dale_coop
		AddValue #$08, myScore, #$01, #$00
		UpdateHud HUD_myScore
		LDX tempy	;;dale_coop

        JSR HandleDrops
        JSR HandleToggleScrolling
		
		CountObjects #%00001000, #$00
		LDA monsterCounter
		CLC	;;dale_coop
		BEQ +
		JMP ++
	+
		.include SCR_KILLED_LAST_MONSTER
	++
        JMP skipHurtingMonsterJumpOnMonster
    notMonsterDeathJumpOnMonster:
        STA Object_health,x
    skipHurtingMonsterJumpOnMonster: 	
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	JMP playerWasHurtDuringCollision
dontJumpOnMonster:
;;---- Jump On Kills code end ----

	
	LDA Object_vulnerability,x
	AND #%01000000 ;; is he lethal invincible?
	BNE isLethalInvincible
	JMP notLethalInvincible
isLethalInvincible:
	LDX tempx
	LDA Object_x_hi,x
	STA temp
	LDA Object_y_hi,x
	STA temp1
	CreateObject temp, temp1, #OBJ_MONSTER_DEATH, #$00, currentNametable ;; create "splat"
	LDX tempx
	
	;;; ordinarily we'll want to destroy the instance.
	 DeactivateCurrentObject
	;; incrase score, you killed a monster
	PlaySound #SND_SPLAT
	TXA
	STA tempx
	AddValue #$08, myScore, #$01, #$00

	;;; we also need to set up the routine to update the HUD
	;; for this to work right, health must be a "blank-then-draw" type element.
	;STA hudElementTilesToLoad
	;	LDA #$00
	;	STA hudElementTilesMax
		; LDA DrawHudBytes
		; ora #HUD_myScore
		; STA DrawHudBytes
	UpdateHud HUD_myScore
	LDX tempx
	;;
	
	JMP skipThisOtherObject
	
notLethalInvincible:
	
	;;;;;;;;;;;;;;;;;
	;;;;;;;;; WHAT HAPPENS WHEN PLAYER IS HURT
	.include SCR_PLAYER_HURT_SCRIPT
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	
	
playerWasHurtDuringCollision:	
	LDX tempx
	JMP skipThisOtherObject
otherIsNotAMonsterTypeCollision:
	;LDA ObjectFlags,y
	LDA Object_flags,x
	AND #%00100000 ;; is it a 'collectable'?
	BEQ otherIsNotAcollectable
	;;;; IS A pickup / power up
	DeactivateCurrentObject ;; makes the other object go away
							;; since other object is loaded in X
							
;;=========== WHAT DO YOU WANT TO HAVE HAPPEN WHEN YOU COLLECT THIS ITEM?

	JSR HandlePickupPowerup

	
otherIsNotAcollectable:
noPlayerObjectCollision:	
skipThisOtherObject:
	INX
	CPX #TOTAL_MAX_OBJECTS
	BEQ doneLoopThroughOtherObjects_player
	JMP LoopThroughOtherObjects_player
doneLoopThroughOtherObjects_player:
	;; end of player collision
	LDX tempx ;; restore x
	JMP doneWithThisObjectCollision
	
	
	
notPlayerType_forObjectCollision:
	;; is of player weapon type.
	JSR GetSelfCollisionBox
	;; now we have the collision box for self object
	;; next we loop through objects.
	LDX #$00
LoopThroughOtherObjects_weapon:

	CPX tempx
	BNE dontskipThisOtherObject_weapon
	JMP skipThisOtherObject_weapon
dontskipThisOtherObject_weapon
	JSR GetOtherCollisionBox
	;; now we can do all the compares
	LDA selfNT_R
	CMP otherNT_L
	BCC + ;; no player object collision
	BNE ++ ;; is still possible to see collision.
	LDA selfRight
	CMP otherLeft
	BCC + ;; no player object collision
++ ;; it is still possible there is a collision here.
	LDA otherNT_R
	CMP selfNT_L
	BCC +
	BNE +++
	LDA otherRight
	CMP selfLeft
	BCC +
	
+++ ;; there was a collision here
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
	LDA otherBottom
	CMP selfTop
	BCC +
	LDA selfBottom
	CMP otherTop
	BCC +

	JMP doWeaponObjectCollision

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;	
+ ;; there is no collision here horizontally.
	JMP noWeaponObjectCollision
doWeaponObjectCollision:
	;; go through the different types of collision possible.
	;; first, check monster OR monser projectile, as that should lead to hurt/death
	;LDY Object_type,x
	;LDA ObjectFlags,y
	LDA Object_flags,x
	AND #%00001000 ;; is it a monster type?
	;;; if you'd like the player weapon to ALSO destroy projectiles
	;;; use #%00011000 here
	BNE otherIsMonsterTypeCollision_weapon
	JMP otherIsNotAMonsterTypeCollision_weapon
otherIsMonsterTypeCollision_weapon:
;;;;;;;;;;;;;;;;;;;;;;;;
	TXA
	PHA
	.include SCR_HANDLE_HURT_MONSTER
	PLA
	TAX
	;;; if monster dies, count monsters
	;; right now, he always dies, so count the monsters.
	JSR countAllMonsters	
	

	
otherIsNotAMonsterTypeCollision_weapon:
	
noWeaponObjectCollision:	
skipThisOtherObject_weapon:
	INX
	CPX #TOTAL_MAX_OBJECTS
	BEQ doneWithLoopingThroughWeaponObjects
	JMP LoopThroughOtherObjects_weapon
doneWithLoopingThroughWeaponObjects:
	
	
	
	;; end of player collision
	LDX tempx ;; restore x
	JMP doneWithThisObjectCollision
	
	
	
	
doneWithThisObjectCollision:
	LDX tempx
	INX
	CPX #TOTAL_MAX_OBJECTS
	BEQ doneWithAllObjects
	JMP CollisionOuterLoop
doneWithAllObjects:
	;;;;;;;;;;;;;;;;;;;;;;;;;
	;; for this module
	;; we will check for the melee position.
	;; but rather than waste space with an entire object
	;; we'll just test it against a single point
	.include SCR_CHECK_SPRITE_WEAPON

	RTS
	
	
	
	
	
	
GetSelfCollisionBox:	
	LDA Object_x_hi,x
	CLC
	ADC Object_left,x
	STA selfLeft
	LDA Object_scroll,x
	ADC #$00
	STA selfNT_L
	
	LDA Object_x_hi,x
	CLC
	ADC Object_right,x
	STA selfRight
	LDA Object_scroll,x
	ADC #$00
	STA selfNT_R
	
	LDA Object_vulnerability,x
	AND #%10000000
	BEQ noDuckingBit
	LDA Object_bottom
	SEC 
	SBC Object_top
	STA temp
	LDA Object_y_hi,x
	CLC
	ADC temp
	JMP gotSelfTop
noDuckingBit:
	LDA Object_y_hi,x
	CLC
	ADC Object_top,x
gotSelfTop:
	STA selfTop
	LDA Object_y_hi,x
	CLC
	ADC Object_bottom,x
	STA selfBottom
	LDA Object_x_hi,x
	CLC
	ADC Object_origin_x,x
	STA selfCenterX
	LDA Object_y_hi,x
	CLC
	ADC Object_origin_y,x
	STA selfCenterY
	

	RTS
	
GetOtherCollisionBox:
	LDA Object_x_hi,x
	CLC
	ADC Object_left,x
	STA otherLeft
	LDA Object_scroll,x
	ADC #$00
	STA otherNT_L
	
	LDA Object_x_hi,x
	CLC
	ADC Object_right,x
	STA otherRight
	LDA Object_scroll,x
	ADC #$00
	STA otherNT_R
	
	LDA Object_vulnerability,x
	AND #%10000000
	BEQ noDuckingBit_other
	LDA Object_bottom
	SEC 
	SBC Object_top
	STA temp
	LDA Object_y_hi,x
	CLC
	ADC temp
	JMP gotSelfTop_other
noDuckingBit_other:
	LDA Object_y_hi,x
	CLC
	ADC Object_top,x
gotSelfTop_other:	
	
	STA otherTop
	LDA Object_y_hi,x
	CLC
	ADC Object_bottom,x
	STA otherBottom
	LDA Object_x_hi,x
	CLC
	ADC Object_origin_x,x
	STA otherCenterX
	LDA Object_y_hi,x
	CLC
	ADC Object_origin_y,x
	STA otherCenterY
	

	RTS
	
	
	
	
	
	
	
DetermineRecoilDirection:

	;;;RECOIL
	;;First check for the abs x value
	LDA recoil_selfX
	SEC
	SBC recoil_otherX
	BCS absCheckDone
	EOR #$FF
	CLC
	ADC #$01
absCheckDone:
	STA temp
	LDA recoil_selfY
	SEC
	SBC recoil_otherY
	BCS absCheckDone2
	EOR #$FF
	CLC
	ADC #$01
absCheckDone2:
	CMP temp
	BCS vCol
	LDA recoil_selfX
	CMP recoil_otherX
	BCS recoilRight
	;; recoil left
	;LDX #$01
	LDA #RECOIL_SPEED_LO
	STA Object_h_speed_lo,x
	LDA #$00
	SEC
	SBC	#RECOIL_SPEED_HI
	STA Object_h_speed_hi,x
	LDA #$00
	STA Object_v_speed_hi,x
	STA Object_v_speed_lo,x
	LDA #%10000000
	STA temp1
	LDA Object_movement,x
	AND #%00000111
	ORA temp1
	STA Object_movement,x
	CPX player1_object
	BNE dontChangeScrollDirectionL
	LDA #$00
	STA scrollDirection
dontChangeScrollDirectionL
	RTS
	
recoilRight:
	;LDX #$01
	LDA #RECOIL_SPEED_LO
	STA Object_h_speed_lo,x
	LDA	#RECOIL_SPEED_HI
	STA Object_h_speed_hi,x
	LDA #$00
	STA Object_v_speed_hi,x
	STA Object_v_speed_lo,x
	LDA #%11000000
	STA temp1
	LDA Object_movement,x
	AND #%00000111
	ORA temp1
	STA Object_movement,x
	CPX player1_object
	BNE dontChangeScrollDirectionR
	LDA #$01
	STA scrollDirection
dontChangeScrollDirectionR:
	RTS
	
vCol:
	LDA recoil_selfY
	CMP recoil_otherY
	BCS recoilDown
	;LDX #$01
	LDA #RECOIL_SPEED_LO
	STA Object_v_speed_lo,x
	LDA #$00
	SEC
	SBC	#RECOIL_SPEED_HI
	STA Object_v_speed_hi,x
	LDA #%00100000
	STA temp1
	LDA #$00
	STA Object_h_speed_hi,x
	STA Object_h_speed_lo,x
	LDA Object_movement,x
	AND #%00000111
	ORA temp1
	STA Object_movement,x

	RTS
	
recoilDown:
	;LDX #$01
	LDA #RECOIL_SPEED_LO
	STA Object_v_speed_lo,x
	LDA #RECOIL_SPEED_HI
	STA Object_v_speed_hi,x
	LDA #%00110000
	STA temp1
	LDA #$00
	STA Object_h_speed_hi,x
	STA Object_h_speed_lo,x
	LDA Object_movement,x
	AND #%00000111
	ORA temp1
	STA Object_movement,x
	
	RTS
	
-----
Sorry about my poor english
All I need: A Damn Fine Cup of Coffee
My games: PRESS START GAME / UNDERGROUND ADVENTURE / UNDERGROUND ADVENTURE (Arcade version - Byte-Off-2019)
My son's game: KUBO 3
User avatar
Winterbeast3
Posts: 8
Joined: Tue Jan 28, 2020 12:13 am
Location: York, PA

Re: Jump On Hurts (modified jump on kills script)

Post by Winterbeast3 » Sun Feb 02, 2020 12:35 pm

Works Great!! You are awesome thank you very much
User avatar
Winterbeast3
Posts: 8
Joined: Tue Jan 28, 2020 12:13 am
Location: York, PA

Re: Jump On Hurts (modified jump on kills script)

Post by Winterbeast3 » Tue Feb 04, 2020 9:56 pm

Hi,
The monster death animation was not playing so after playing around I tried adding line 300 after line 261 and now it works great. So basically I added the create monster object line after line 261. Here's the entire script.

Code: Select all

;; LOAD OBJECT 00
;; OUTER LOOP
;; CHECK IF ACTIVE, IF NOT, SKIP OBJECT
;; LOAD self-collision-box
;; START OBJECT COLLISION LOOP
    ;; LDA ONE MORE THAN CURRENT OBJECT
    ;; CHECK IF ACTIVE.  IF NOT, SKIP THIS other
    ;; IF IT IS ACTIVE, then we have to play them against each other.
        ;; IS self object hurt by monsters?  If so, and other object is a monster, respond.
        ;; IS self object hurt by weapons?  If so, and other object is a weapon, respond.
        ;; at this point, we can still gauge whether or not it's affected by player, like with powerups.
        ;; ADD one to the object being checked, loop through other objects.
;; increase object, return to outer loop.  Repeat thorugh all self objects.

;; ObjectFlags:
;; 7 - 6 - 5 - 4 - 3 - 2 - 1 - 0
;  |   |   |   |   |   |   |   + -- PERSISTENT (especially good for player!)
;  |   |   |   |   |   |   +------- player type
;  |   |   |   |   |   + ---------- player weapon/projectile type
;  |   |   |   |   +--------------- monster type
;  |   |   |   +------------------- monster weapon/projectile type
;  |   |   +----------------------- pickup / power up
;  |   + -------------------------- target type 
;  +------------------------------- NPC type

;; player type checks monster, mosnter weapon, and pickup.
;; player weapon checks monster and target.
;; nothing else needs checking, as it would all be handled by those two steps.
;; so if it's a monster, do nothing.  if it's a monster projectile, do nothing. 
;; if it's a pickup, or a target, or it ignores all collisions, do nothing.
;; only if it's #%00000110, do something.



HandleObjectCollisions:

    LDA update_screen
    BEQ notChangingScreens
    rts
notChangingScreens:
    
    LDA npc_collision
    AND #%11111110
    STA npc_collision

    ;LDA currentBank
    ;STA prevBank
    ;LDY #BANK_ANIMS
    ;JSR bankswitchY
    
    LDX #$00
CollisionOuterLoop:
    TXA
    STA tempx
    LDA Object_status,x
    AND #%10000000
    BNE continueObjectCollisions_objectIsActive
    JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsActive:
    LDA Object_status,x
    AND #%00000100 ;; is ot off screen
    BEQ continueObjectCollisions_objectIsOnScreen
    JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsOnScreen
    LDA Object_status,x
    AND #%00000011
    BEQ continueObjectCollisions_objectIsNotHurtOrInvincible
    JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsNotHurtOrInvincible
    ;LDY Object_type,x
    ;LDA ObjectFlags,y
    LDA Object_flags,x
    AND #%00000110
    BNE continueObjectCollisions_onlyPlayerTypesCheck
    JMP doneWithThisObjectCollision
continueObjectCollisions_onlyPlayerTypesCheck:
    ;; this is either a player or player projectile type of object.
    ;; all other types will be taken care of by iterating through these two types.
    ;; first, check if it's player type.
    ;LdA ObjectFlags,y
    LDA Object_flags,x
    AND #%00000010
    BNE isPlayerTypeForCollision
    JMP notPlayerType_forObjectCollision
isPlayerTypeForCollision:
    LDA player1_object
    STA colX
    ;; is player type for object collision
    ;; player's index is loaded into tempx
    JSR GetSelfCollisionBox
    ;; now we have the collision box for self object
    ;; next we loop through objects.
    
    LDX #$00
LoopThroughOtherObjects_player:
    CPX tempx
    BNE dontSkipThisOtherObject
    JMP skipThisOtherObject ;; other object IS the player, the one doing the counting..
dontSkipThisOtherObject:
    LDA Object_status,x
    AND #%00000100
    BEQ dontSkipThisOtherObject_becauseOnScreen
    JMP skipThisOtherObject ;; because it was off screen.
dontSkipThisOtherObject_becauseOnScreen:

    JSR GetOtherCollisionBox
    

    ;; now we can do all the compares
    LDA selfNT_R
    CMP otherNT_L
    BCC + ;; no player object collision
    BNE ++ ;; is still possible to see collision.
    LDA selfRight
    CMP otherLeft
    BCC + ;; no player object collision
++ ;; it is still possible there is a collision here.
    LDA otherNT_R
    CMP selfNT_L
    BCC +
    BNE +++
    LDA otherRight
    CMP selfLeft
    BCC +
    
+++ ;; there was a collision here
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
    LDA otherBottom
    CMP selfTop
    BCC +
    LDA selfBottom
    CMP otherTop
    BCC +

    JMP DoPlayerObjectCollision

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;    
+ ;; there is no collision here horizontally.
    JMP noPlayerObjectCollision

DoPlayerObjectCollision:


    
    LDA Object_flags,x
    AND #%10000000 ;; is it an NPC
    BNE isAnNPC
    ;; is not an NPC
    JMP isNotAnNPCcollision
isAnNPC:
    ;;;; do npc stuff.
    LDA npc_collision
    ORA #%00000001
    STA npc_collision
    ;;;; enables a button to be used to activate a textbox.
    LDA Object_ID,x
    STA textVar
    ;LDA gameHandler
    ;ORA #%00100000
    ;STA gameHandler

    JMP skipThisOtherObject
    
isNotAnNPCcollision:    
    LDA Object_flags,x
    ;LDA ObjectFlags,y
    AND #%00011000 ;; is it a monster type?
    BNE otherIsAMonsterTypeCollision
    JMP otherIsNotAMonsterTypeCollision
otherIsAMonsterTypeCollision:
    LDA Object_status,x
    AND #HURT_STATUS_MASK ;; if the monster is hurt, it can't hurt us
    BEQ yesPlayerObjectCollision
    JMP noPlayerObjectCollision
yesPlayerObjectCollision:
    
    LDA Object_vulnerability,x
    AND #%00000010 ;; in this module, this is ignore player collision
    BEQ doPlayerHurt
    JMP noPlayerObjectCollision
doPlayerHurt:
    ;;;observe health
    TXA
    STA tempx ;; object is in tempx.
    LDX player1_object
    LDA Object_status,x
    AND #HURT_STATUS_MASK
    BEQ playerWasNotHurtDuringCollision
    JMP playerWasHurtDuringCollision
playerWasNotHurtDuringCollision:
;;---- Jump On Kills code begin ----
    TYA
    STA tempy
    LDX tempx
    LDA Object_vulnerability,x
    AND #%00010000
    BNE jumpOnMonster
    LDX player1_object
    JMP dontJumpOnMonster
jumpOnMonster:
    LDX player1_object
    LDA selfBottom
    CMP otherCenterY
    BCC +
    JMP dontJumpOnMonster
    +
    ;;; JUMP ON MONSTER
    ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
    LDA #$00
    SEC
    SBC #$04
    STA Object_v_speed_hi,x
    
    LDX tempx

        LDA Object_status,x
        AND #HURT_STATUS_MASK
        BEQ dontskipHurtingMonsterJumpOnMonster
        JMP skipHurtingMonsterJumpOnMonster
    dontskipHurtingMonsterJumpOnMonster:
        LDA Object_status,x
        ORA #%00000001
        STA Object_status,x
        LDA #HURT_TIMER
        STA Object_timer_0,x
        ;;; assume idle is in step 0
        ChangeObjectState #$00,#$02
        ;;;; unfortunately this recoil is backwards
        LDA Object_status,x
        AND #%00000100
        BNE skipRecoilBecauseOnEdgeJumpOnMonster
        LDA Object_vulnerability,x
        AND #%00001000 
        BNE skipRecoilBecauseOnEdgeJumpOnMonster ;; skip recoil because bit is flipped to ignore recoil
        
        LDA selfCenterX
        STA recoil_otherX
        LDA selfCenterY
        STA recoil_otherY
        LDA otherCenterX
        STA recoil_selfX
        LDA otherCenterY
        STA recoil_selfY
        JSR DetermineRecoilDirection
    skipRecoilBecauseOnEdgeJumpOnMonster:
        LDA Object_health,x
        SEC
        SBC #$01
        CMP #$01
        BCC +
        JMP notMonsterDeathJumpOnMonster
    +

        LDA Object_x_hi,x
        STA temp
        LDA Object_y_hi,x
        STA temp1
        LDA Object_scroll,x
        STA temp2
      
        DeactivateCurrentObject
        CreateObject temp, temp1, #OBJ_MONSTER_DEATH, #$00, currentNametable ;; create "splat"
       
        PlaySound #SND_SPLAT
    
        STX tempy   ;;dale_coop
        AddValue #$08, myScore, #$01, #$02
        UpdateHud HUD_myScore
        LDX tempy   ;;dale_coop

        JSR HandleDrops
        JSR HandleToggleScrolling
        
        CountObjects #%00001000, #$00
        LDA monsterCounter
        CLC ;;dale_coop
        BEQ +
        JMP ++
    +
        .include SCR_KILLED_LAST_MONSTER
    ++
        JMP skipHurtingMonsterJumpOnMonster
    notMonsterDeathJumpOnMonster:
        STA Object_health,x
    skipHurtingMonsterJumpOnMonster:    
    ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
    JMP playerWasHurtDuringCollision
dontJumpOnMonster:
;;---- Jump On Kills code end ----

    
    LDA Object_vulnerability,x
    AND #%01000000 ;; is he lethal invincible?
    BNE isLethalInvincible
    JMP notLethalInvincible
isLethalInvincible:
    LDX tempx
    LDA Object_x_hi,x
    STA temp
    LDA Object_y_hi,x
    STA temp1
    CreateObject temp, temp1, #OBJ_MONSTER_DEATH, #$00, currentNametable ;; create "splat"
    LDX tempx
    
    ;;; ordinarily we'll want to destroy the instance.
     DeactivateCurrentObject
    ;; incrase score, you killed a monster
    PlaySound #SND_SPLAT
    TXA
    STA tempx
    AddValue #$08, myScore, #$01, #$00

    ;;; we also need to set up the routine to update the HUD
    ;; for this to work right, health must be a "blank-then-draw" type element.
    ;STA hudElementTilesToLoad
    ;   LDA #$00
    ;   STA hudElementTilesMax
        ; LDA DrawHudBytes
        ; ora #HUD_myScore
        ; STA DrawHudBytes
    UpdateHud HUD_myScore
    LDX tempx
    ;;
    
    JMP skipThisOtherObject
    
notLethalInvincible:
    
    ;;;;;;;;;;;;;;;;;
    ;;;;;;;;; WHAT HAPPENS WHEN PLAYER IS HURT
    .include SCR_PLAYER_HURT_SCRIPT
    ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
    ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
    
    
playerWasHurtDuringCollision:   
    LDX tempx
    JMP skipThisOtherObject
otherIsNotAMonsterTypeCollision:
    ;LDA ObjectFlags,y
    LDA Object_flags,x
    AND #%00100000 ;; is it a 'collectable'?
    BEQ otherIsNotAcollectable
    ;;;; IS A pickup / power up
    DeactivateCurrentObject ;; makes the other object go away
                            ;; since other object is loaded in X
                            
;;=========== WHAT DO YOU WANT TO HAVE HAPPEN WHEN YOU COLLECT THIS ITEM?

    JSR HandlePickupPowerup

    
otherIsNotAcollectable:
noPlayerObjectCollision:    
skipThisOtherObject:
    INX
    CPX #TOTAL_MAX_OBJECTS
    BEQ doneLoopThroughOtherObjects_player
    JMP LoopThroughOtherObjects_player
doneLoopThroughOtherObjects_player:
    ;; end of player collision
    LDX tempx ;; restore x
    JMP doneWithThisObjectCollision
    
    
    
notPlayerType_forObjectCollision:
    ;; is of player weapon type.
    JSR GetSelfCollisionBox
    ;; now we have the collision box for self object
    ;; next we loop through objects.
    LDX #$00
LoopThroughOtherObjects_weapon:

    CPX tempx
    BNE dontskipThisOtherObject_weapon
    JMP skipThisOtherObject_weapon
dontskipThisOtherObject_weapon
    JSR GetOtherCollisionBox
    ;; now we can do all the compares
    LDA selfNT_R
    CMP otherNT_L
    BCC + ;; no player object collision
    BNE ++ ;; is still possible to see collision.
    LDA selfRight
    CMP otherLeft
    BCC + ;; no player object collision
++ ;; it is still possible there is a collision here.
    LDA otherNT_R
    CMP selfNT_L
    BCC +
    BNE +++
    LDA otherRight
    CMP selfLeft
    BCC +
    
+++ ;; there was a collision here
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
    LDA otherBottom
    CMP selfTop
    BCC +
    LDA selfBottom
    CMP otherTop
    BCC +

    JMP doWeaponObjectCollision

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;    
+ ;; there is no collision here horizontally.
    JMP noWeaponObjectCollision
doWeaponObjectCollision:
    ;; go through the different types of collision possible.
    ;; first, check monster OR monser projectile, as that should lead to hurt/death
    ;LDY Object_type,x
    ;LDA ObjectFlags,y
    LDA Object_flags,x
    AND #%00001000 ;; is it a monster type?
    ;;; if you'd like the player weapon to ALSO destroy projectiles
    ;;; use #%00011000 here
    BNE otherIsMonsterTypeCollision_weapon
    JMP otherIsNotAMonsterTypeCollision_weapon
otherIsMonsterTypeCollision_weapon:
;;;;;;;;;;;;;;;;;;;;;;;;
    TXA
    PHA
    .include SCR_HANDLE_HURT_MONSTER
    PLA
    TAX
    ;;; if monster dies, count monsters
    ;; right now, he always dies, so count the monsters.
    JSR countAllMonsters    
    

    
otherIsNotAMonsterTypeCollision_weapon:
    
noWeaponObjectCollision:    
skipThisOtherObject_weapon:
    INX
    CPX #TOTAL_MAX_OBJECTS
    BEQ doneWithLoopingThroughWeaponObjects
    JMP LoopThroughOtherObjects_weapon
doneWithLoopingThroughWeaponObjects:
    
    
    
    ;; end of player collision
    LDX tempx ;; restore x
    JMP doneWithThisObjectCollision
    
    
    
    
doneWithThisObjectCollision:
    LDX tempx
    INX
    CPX #TOTAL_MAX_OBJECTS
    BEQ doneWithAllObjects
    JMP CollisionOuterLoop
doneWithAllObjects:
    ;;;;;;;;;;;;;;;;;;;;;;;;;
    ;; for this module
    ;; we will check for the melee position.
    ;; but rather than waste space with an entire object
    ;; we'll just test it against a single point
    .include SCR_CHECK_SPRITE_WEAPON

    RTS
    
    
    
    
    
    
GetSelfCollisionBox:    
    LDA Object_x_hi,x
    CLC
    ADC Object_left,x
    STA selfLeft
    LDA Object_scroll,x
    ADC #$00
    STA selfNT_L
    
    LDA Object_x_hi,x
    CLC
    ADC Object_right,x
    STA selfRight
    LDA Object_scroll,x
    ADC #$00
    STA selfNT_R
    
    LDA Object_vulnerability,x
    AND #%10000000
    BEQ noDuckingBit
    LDA Object_bottom
    SEC 
    SBC Object_top
    STA temp
    LDA Object_y_hi,x
    CLC
    ADC temp
    JMP gotSelfTop
noDuckingBit:
    LDA Object_y_hi,x
    CLC
    ADC Object_top,x
gotSelfTop:
    STA selfTop
    LDA Object_y_hi,x
    CLC
    ADC Object_bottom,x
    STA selfBottom
    LDA Object_x_hi,x
    CLC
    ADC Object_origin_x,x
    STA selfCenterX
    LDA Object_y_hi,x
    CLC
    ADC Object_origin_y,x
    STA selfCenterY
    

    RTS
    
GetOtherCollisionBox:
    LDA Object_x_hi,x
    CLC
    ADC Object_left,x
    STA otherLeft
    LDA Object_scroll,x
    ADC #$00
    STA otherNT_L
    
    LDA Object_x_hi,x
    CLC
    ADC Object_right,x
    STA otherRight
    LDA Object_scroll,x
    ADC #$00
    STA otherNT_R
    
    LDA Object_vulnerability,x
    AND #%10000000
    BEQ noDuckingBit_other
    LDA Object_bottom
    SEC 
    SBC Object_top
    STA temp
    LDA Object_y_hi,x
    CLC
    ADC temp
    JMP gotSelfTop_other
noDuckingBit_other:
    LDA Object_y_hi,x
    CLC
    ADC Object_top,x
gotSelfTop_other:   
    
    STA otherTop
    LDA Object_y_hi,x
    CLC
    ADC Object_bottom,x
    STA otherBottom
    LDA Object_x_hi,x
    CLC
    ADC Object_origin_x,x
    STA otherCenterX
    LDA Object_y_hi,x
    CLC
    ADC Object_origin_y,x
    STA otherCenterY
    

    RTS
    
    
    
    
    
    
    
DetermineRecoilDirection:

    ;;;RECOIL
    ;;First check for the abs x value
    LDA recoil_selfX
    SEC
    SBC recoil_otherX
    BCS absCheckDone
    EOR #$FF
    CLC
    ADC #$01
absCheckDone:
    STA temp
    LDA recoil_selfY
    SEC
    SBC recoil_otherY
    BCS absCheckDone2
    EOR #$FF
    CLC
    ADC #$01
absCheckDone2:
    CMP temp
    BCS vCol
    LDA recoil_selfX
    CMP recoil_otherX
    BCS recoilRight
    ;; recoil left
    ;LDX #$01
    LDA #RECOIL_SPEED_LO
    STA Object_h_speed_lo,x
    LDA #$00
    SEC
    SBC #RECOIL_SPEED_HI
    STA Object_h_speed_hi,x
    LDA #$00
    STA Object_v_speed_hi,x
    STA Object_v_speed_lo,x
    LDA #%10000000
    STA temp1
    LDA Object_movement,x
    AND #%00000111
    ORA temp1
    STA Object_movement,x
    CPX player1_object
    BNE dontChangeScrollDirectionL
    LDA #$00
    STA scrollDirection
dontChangeScrollDirectionL
    RTS
    
recoilRight:
    ;LDX #$01
    LDA #RECOIL_SPEED_LO
    STA Object_h_speed_lo,x
    LDA #RECOIL_SPEED_HI
    STA Object_h_speed_hi,x
    LDA #$00
    STA Object_v_speed_hi,x
    STA Object_v_speed_lo,x
    LDA #%11000000
    STA temp1
    LDA Object_movement,x
    AND #%00000111
    ORA temp1
    STA Object_movement,x
    CPX player1_object
    BNE dontChangeScrollDirectionR
    LDA #$01
    STA scrollDirection
dontChangeScrollDirectionR:
    RTS
    
vCol:
    LDA recoil_selfY
    CMP recoil_otherY
    BCS recoilDown
    ;LDX #$01
    LDA #RECOIL_SPEED_LO
    STA Object_v_speed_lo,x
    LDA #$00
    SEC
    SBC #RECOIL_SPEED_HI
    STA Object_v_speed_hi,x
    LDA #%00100000
    STA temp1
    LDA #$00
    STA Object_h_speed_hi,x
    STA Object_h_speed_lo,x
    LDA Object_movement,x
    AND #%00000111
    ORA temp1
    STA Object_movement,x

    RTS
    
recoilDown:
    ;LDX #$01
    LDA #RECOIL_SPEED_LO
    STA Object_v_speed_lo,x
    LDA #RECOIL_SPEED_HI
    STA Object_v_speed_hi,x
    LDA #%00110000
    STA temp1
    LDA #$00
    STA Object_h_speed_hi,x
    STA Object_h_speed_lo,x
    LDA Object_movement,x
    AND #%00000111
    ORA temp1
    STA Object_movement,x
    
    RTS
Post Reply