Which object is the default monster object death?
- Thread starter drexegar
- Start date
Icon-Ninja said:
If you are using the melee object...
Modify your HandleMonsterHurt.asm script around line 97 and 108, the ones just after the CreateObject line... rename "tempx" to "tempy". ONLY for those two lines! (Don’t rename the one at the end of the script).
Your monster death object will work better
Icon-Ninja
New member
dale_coop said:
Gagne! Merci beaucoup, mon ami!
BentPawGames
Member
I think I've lost track of what works here. My monsterhurt asm only goes up to line 97, so perhaps I am missing something?
Icon-Ninja
New member
BentPawGames said:
Look for this section of script towards the end of the asm (mine only has 102 lines, so it threw me off for a second, too):
TXA
STA tempy <<<<<Change this one...
AddValue #$08, myScore, #$01, #$00
;STA hudElementTilesToLoad
; LDA #$00
; STA hudElementTilesMax
; LDA DrawHudBytes
; ora #HUD_myScore
; STA DrawHudBytes
UpdateHud HUD_myScore
LDX tempy<<<<<<And this one.
JSR HandleDrops
JSR HandleToggleScrolling
CountObjects #$00001000, #$00
BEQ +
JMP ++
+
.include SCR_KILLED_LAST_MONSTER
++
JMP skipHurtingMonster
notMonsterDeath
STA Object_health,x
skipHurtingMonster:
;PlaySound #SFX_MONSTER_HURT
skipHurtingMonsterAndSound:
LDX tempx
;; what should we do with the projectile?
DeactivateCurrentObject
Yep those lines, you right Icon-Ninja
Sorry guys, I check a lot of scripts... and sometimes there are empty lines in the scripts, so lines are no more at the same place...
In the default HandleMonsterHurt.asm it should be around lines 67 and 78 (or very close to that):
Sorry guys, I check a lot of scripts... and sometimes there are empty lines in the scripts, so lines are no more at the same place
... In the default HandleMonsterHurt.asm it should be around lines 67 and 78 (or very close to that):
Code:
TXA
STA tempy ;; <-- Change this one...
AddValue #$08, myScore, #$01, #$00
;STA hudElementTilesToLoad
; LDA #$00
; STA hudElementTilesMax
; LDA DrawHudBytes
; ora #HUD_myScore
; STA DrawHudBytes
UpdateHud HUD_myScore
LDX tempy ;; <-- And this one.BentPawGames
Member
Ok cool thank you I already had those set to tempy as part of getting the melee object to not disappear when colliding with enemies, so I am not sure why my enemy death animation doesn't work, but I'll keep working away at it
I already had those set to tempy as part of getting the melee object to not disappear when colliding with enemies, so I am not sure why my enemy death animation doesn't work, but I'll keep working away at it
Check that your player doesn’t have « harmful invincible » set to any of his actions steps.
Also, check that your « use sprite weapon » element in « Project settings > Script settings » is deactivated (assigned to a blank script).
Check that the obj_monster_death user constant value is correct.
Also, check that your « use sprite weapon » element in « Project settings > Script settings » is deactivated (assigned to a blank script).
Check that the obj_monster_death user constant value is correct.
BentPawGames
Member
Hmm still doesn't work for me.
I have obj_monster_death set to 9. In the 9th spot under game objects is my monster death animation. The death animation is set as an enemy, has a timer and is set to destroy me after action. I deactivated the sprite weapon asm like Dale suggested. I changed that section of code from tempx to tempy in handlemonsterhurt. I am using this code in handlemonsterhurt:
LDA Object_x_hi,x
STA temp
LDA Object_y_hi,x
STA temp1
DeactivateCurrentObject
CreateObject temp, temp1, #OBJ_MONSTER_DEATH, #$00, currentNametable
I have obj_monster_death set to 9. In the 9th spot under game objects is my monster death animation. The death animation is set as an enemy, has a timer and is set to destroy me after action. I deactivated the sprite weapon asm like Dale suggested. I changed that section of code from tempx to tempy in handlemonsterhurt. I am using this code in handlemonsterhurt:
LDA Object_x_hi,x
STA temp
LDA Object_y_hi,x
STA temp1
DeactivateCurrentObject
CreateObject temp, temp1, #OBJ_MONSTER_DEATH, #$00, currentNametable
Looks correct, that should work...
9th ? starting from 0th right (Player is 0, Melee 1st, ...)?
Check that you don't have the "harmful invincible" set to any of your player's action steps.
Also, (not directly related to your issue but) your monster death animation should not be set as monster... just an object without any particular type (else the animation could hurt your player).
9th ? starting from 0th right (Player is 0, Melee 1st, ...)?
Check that you don't have the "harmful invincible" set to any of your player's action steps.
Also, (not directly related to your issue but) your monster death animation should not be set as monster... just an object without any particular type (else the animation could hurt your player).
BentPawGames
Member
Yep starting from zero. No harmful invincible is checked off.
Ah ok, I was just going off of the video posted in this thread which appeared to check off "monster"
I'll keep looking at it and triple checking there's nothing I missed
Ah ok, I was just going off of the video posted in this thread which appeared to check off "monster"
I'll keep looking at it and triple checking there's nothing I missed
If you want to keep your weapon, comment out the lines:Lother said:
Code:
;;LDX tempx
;; what should we do with the projectile?
;;DeactivateCurrentObjectLother said:
Could you share screenshots of your Player action step 3
Could you share:
- the script (copy/paste the content) assigned to your "Handle monster hurt" element in "Project Settings > Script Settings"
- the script (copy/paste the content) assigned to your "Use Sprite Based Weapon" element in "Project Settings > Script Settings"
- the script (copy/paste the content) assigned to your "Handle Sprite Pre-Draw" element in "Project Settings > Script Settings"
Need ALL that
n8bit said:
Exact n8bit, in the JumpOn Kills tutorial, locate the
Code:
DeactivateCurrentObject
Code:
;; DeactivateCurrentObject
LDA Object_x_hi,x
STA temp
LDA Object_y_hi,x
STA temp1
CreateObject temp, temp1, #OBJ_KAISER_MONSTER_DEATH, #$00, currentNametable ;; create "splat"
LDX tempx
DeactivateCurrentObject
n8bit
Member
Caused the following error...dale_coop said:
Routines\BASIC_021019\ModuleScripts\MainScripts\ScrollingPlatformer\HandleObjectCollisions_withJumpOnKills.asm(208): Branch out of range.
Here is my JumpOnKills script...
Code:
;; LOAD OBJECT 00
;; OUTER LOOP
;; CHECK IF ACTIVE, IF NOT, SKIP OBJECT
;; LOAD self-collision-box
;; START OBJECT COLLISION LOOP
;; LDA ONE MORE THAN CURRENT OBJECT
;; CHECK IF ACTIVE. IF NOT, SKIP THIS other
;; IF IT IS ACTIVE, then we have to play them against each other.
;; IS self object hurt by monsters? If so, and other object is a monster, respond.
;; IS self object hurt by weapons? If so, and other object is a weapon, respond.
;; at this point, we can still gauge whether or not it's affected by player, like with powerups.
;; ADD one to the object being checked, loop through other objects.
;; increase object, return to outer loop. Repeat thorugh all self objects.
;; ObjectFlags:
;; 7 - 6 - 5 - 4 - 3 - 2 - 1 - 0
; | | | | | | | + -- PERSISTENT (especially good for player!)
; | | | | | | +------- player type
; | | | | | + ---------- player weapon/projectile type
; | | | | +--------------- monster type
; | | | +------------------- monster weapon/projectile type
; | | +----------------------- pickup / power up
; | + -------------------------- target type
; +------------------------------- NPC type
;; player type checks monster, mosnter weapon, and pickup.
;; player weapon checks monster and target.
;; nothing else needs checking, as it would all be handled by those two steps.
;; so if it's a monster, do nothing. if it's a monster projectile, do nothing.
;; if it's a pickup, or a target, or it ignores all collisions, do nothing.
;; only if it's #%00000110, do something.
HandleObjectCollisions:
LDA update_screen
BEQ notChangingScreens
rts
notChangingScreens:
LDA npc_collision
AND #%11111110
STA npc_collision
;LDA currentBank
;STA prevBank
;LDY #BANK_ANIMS
;JSR bankswitchY
LDX #$00
CollisionOuterLoop:
TXA
STA tempx
LDA Object_status,x
AND #%10000000
BNE continueObjectCollisions_objectIsActive
JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsActive:
LDA Object_status,x
AND #%00000100 ;; is ot off screen
BEQ continueObjectCollisions_objectIsOnScreen
JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsOnScreen
LDA Object_status,x
AND #%00000011
BEQ continueObjectCollisions_objectIsNotHurtOrInvincible
JMP doneWithThisObjectCollision
continueObjectCollisions_objectIsNotHurtOrInvincible
;LDY Object_type,x
;LDA ObjectFlags,y
LDA Object_flags,x
AND #%00000110
BNE continueObjectCollisions_onlyPlayerTypesCheck
JMP doneWithThisObjectCollision
continueObjectCollisions_onlyPlayerTypesCheck:
;; this is either a player or player projectile type of object.
;; all other types will be taken care of by iterating through these two types.
;; first, check if it's player type.
;LdA ObjectFlags,y
LDA Object_flags,x
AND #%00000010
BNE isPlayerTypeForCollision
JMP notPlayerType_forObjectCollision
isPlayerTypeForCollision:
LDA player1_object
STA colX
;; is player type for object collision
;; player's index is loaded into tempx
JSR GetSelfCollisionBox
;; now we have the collision box for self object
;; next we loop through objects.
LDX #$00
LoopThroughOtherObjects_player:
CPX tempx
BNE dontSkipThisOtherObject
JMP skipThisOtherObject ;; other object IS the player, the one doing the counting..
dontSkipThisOtherObject:
LDA Object_status,x
AND #%00000100
BEQ dontSkipThisOtherObject_becauseOnScreen
JMP skipThisOtherObject ;; because it was off screen.
dontSkipThisOtherObject_becauseOnScreen:
JSR GetOtherCollisionBox
;; now we can do all the compares
LDA selfNT_R
CMP otherNT_L
BCC + ;; no player object collision
BNE ++ ;; is still possible to see collision.
LDA selfRight
CMP otherLeft
BCC + ;; no player object collision
++ ;; it is still possible there is a collision here.
LDA otherNT_R
CMP selfNT_L
BCC +
BNE +++
LDA otherRight
CMP selfLeft
BCC +
+++ ;; there was a collision here
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
LDA otherBottom
CMP selfTop
BCC +
LDA selfBottom
CMP otherTop
BCC +
JMP DoPlayerObjectCollision
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+ ;; there is no collision here horizontally.
JMP noPlayerObjectCollision
DoPlayerObjectCollision:
LDA Object_flags,x
AND #%10000000 ;; is it an NPC
BNE isAnNPC
;; is not an NPC
JMP isNotAnNPCcollision
isAnNPC:
;;;; do npc stuff.
LDA npc_collision
ORA #%00000001
STA npc_collision
;;;; enables a button to be used to activate a textbox.
LDA Object_ID,x
STA textVar
;LDA gameHandler
;ORA #%00100000
;STA gameHandler
JMP skipThisOtherObject
isNotAnNPCcollision:
LDA Object_flags,x
;LDA ObjectFlags,y
AND #%00011000 ;; is it a monster type?
BNE otherIsAMonsterTypeCollision
JMP otherIsNotAMonsterTypeCollision
otherIsAMonsterTypeCollision:
LDA Object_status,x
AND #HURT_STATUS_MASK ;; if the monster is hurt, it can't hurt us
BEQ yesPlayerObjectCollision
JMP noPlayerObjectCollision
yesPlayerObjectCollision:
LDA Object_vulnerability,x
AND #%00000010 ;; in this module, this is ignore player collision
BEQ doPlayerHurt
JMP noPlayerObjectCollision
doPlayerHurt:
;;;observe health
TXA
STA tempx ;; object is in tempx.
LDX player1_object
LDA Object_status,x
AND #HURT_STATUS_MASK
BEQ playerWasNotHurtDuringCollision
JMP playerWasHurtDuringCollision
playerWasNotHurtDuringCollision:
;;---- Jump On Kills code begin ----
TYA
STA tempy
LDX tempx
LDA Object_vulnerability,x
AND #%00010000
BNE jumpOnMonster
LDX player1_object
JMP dontJumpOnMonster
jumpOnMonster:
LDX player1_object
;TXA
;STA tempx
;JMP playerWasHurtDuringCollision
;LDX player1_object
LDA selfBottom
CMP otherCenterY
BCS dontJumpOnMonster
;;; JUMP ON MONSTER
LDX player1_object
LDA #$00
SEC
SBC #$04
STA Object_v_speed_hi,x
LDX tempx
LDA Object_health,x
SEC
SBC #$01
CMP #$01
BCC +
JMP notMunsterDeath
+
;;;;DeactivateCurrentObject
LDA Object_x_hi,x
STA temp
LDA Object_y_hi,x
STA temp1
CreateObject temp, temp1, #$09, #$00, currentNametable ;; create "splat"
LDX tempx
DeactivateCurrentObject
LDY tempy
;; INCREASE SCORE
AddValue #$08, myScore, #$01, #$02
UpdateHud HUD_myScore
JMP playerWasHurtDuringCollision ;; just skips collision
dontJumpOnMonster:
notMunsterDeath:
;;---- Jump On Kills code end ----
LDA Object_vulnerability,x
AND #%01000000 ;; is he lethal invincible?
BNE isLethalInvincible
JMP notLethalInvincible
isLethalInvincible:
LDX tempx
LDA Object_x_hi,x
STA temp
LDA Object_y_hi,x
STA temp1
CreateObject temp, temp1, #OBJ_MONSTER_DEATH, #$00, currentNametable ;; create "splat"
LDX tempx
;;; ordinarily we'll want to destroy the instance.
DeactivateCurrentObject
;; incrase score, you killed a monster
PlaySound #SND_SPLAT
TXA
STA tempx
AddValue #$08, myScore, #$01, #$00
;;; we also need to set up the routine to update the HUD
;; for this to work right, health must be a "blank-then-draw" type element.
;STA hudElementTilesToLoad
; LDA #$00
; STA hudElementTilesMax
; LDA DrawHudBytes
; ora #HUD_myScore
; STA DrawHudBytes
UpdateHud HUD_myScore
LDX tempx
;;
JMP skipThisOtherObject
notLethalInvincible:
;;;;;;;;;;;;;;;;;
;;;;;;;;; WHAT HAPPENS WHEN PLAYER IS HURT
.include SCR_PLAYER_HURT_SCRIPT
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
playerWasHurtDuringCollision:
LDX tempx
JMP skipThisOtherObject
otherIsNotAMonsterTypeCollision:
;LDA ObjectFlags,y
LDA Object_flags,x
AND #%00100000 ;; is it a 'collectable'?
BEQ otherIsNotAcollectable
;;;; IS A pickup / power up
DeactivateCurrentObject ;; makes the other object go away
;; since other object is loaded in X
;;=========== WHAT DO YOU WANT TO HAVE HAPPEN WHEN YOU COLLECT THIS ITEM?
JSR HandlePickupPowerup
otherIsNotAcollectable:
noPlayerObjectCollision:
skipThisOtherObject:
INX
CPX #TOTAL_MAX_OBJECTS
BEQ doneLoopThroughOtherObjects_player
JMP LoopThroughOtherObjects_player
doneLoopThroughOtherObjects_player:
;; end of player collision
LDX tempx ;; restore x
JMP doneWithThisObjectCollision
notPlayerType_forObjectCollision:
;; is of player weapon type.
JSR GetSelfCollisionBox
;; now we have the collision box for self object
;; next we loop through objects.
LDX #$00
LoopThroughOtherObjects_weapon:
CPX tempx
BNE dontskipThisOtherObject_weapon
JMP skipThisOtherObject_weapon
dontskipThisOtherObject_weapon
JSR GetOtherCollisionBox
;; now we can do all the compares
LDA selfNT_R
CMP otherNT_L
BCC + ;; no player object collision
BNE ++ ;; is still possible to see collision.
LDA selfRight
CMP otherLeft
BCC + ;; no player object collision
++ ;; it is still possible there is a collision here.
LDA otherNT_R
CMP selfNT_L
BCC +
BNE +++
LDA otherRight
CMP selfLeft
BCC +
+++ ;; there was a collision here
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
LDA otherBottom
CMP selfTop
BCC +
LDA selfBottom
CMP otherTop
BCC +
JMP doWeaponObjectCollision
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+ ;; there is no collision here horizontally.
JMP noWeaponObjectCollision
doWeaponObjectCollision:
;; go through the different types of collision possible.
;; first, check monster OR monser projectile, as that should lead to hurt/death
;LDY Object_type,x
;LDA ObjectFlags,y
LDA Object_flags,x
AND #%00001000 ;; is it a monster type?
;;; if you'd like the player weapon to ALSO destroy projectiles
;;; use #%00011000 here
BNE otherIsMonsterTypeCollision_weapon
JMP otherIsNotAMonsterTypeCollision_weapon
otherIsMonsterTypeCollision_weapon:
;;;;;;;;;;;;;;;;;;;;;;;;
TXA
PHA
.include SCR_HANDLE_HURT_MONSTER
PLA
TAX
;;; if monster dies, count monsters
;; right now, he always dies, so count the monsters.
JSR countAllMonsters
otherIsNotAMonsterTypeCollision_weapon:
noWeaponObjectCollision:
skipThisOtherObject_weapon:
INX
CPX #TOTAL_MAX_OBJECTS
BEQ doneWithLoopingThroughWeaponObjects
JMP LoopThroughOtherObjects_weapon
doneWithLoopingThroughWeaponObjects:
;; end of player collision
LDX tempx ;; restore x
JMP doneWithThisObjectCollision
doneWithThisObjectCollision:
LDX tempx
INX
CPX #TOTAL_MAX_OBJECTS
BEQ doneWithAllObjects
JMP CollisionOuterLoop
doneWithAllObjects:
;;;;;;;;;;;;;;;;;;;;;;;;;
;; for this module
;; we will check for the melee position.
;; but rather than waste space with an entire object
;; we'll just test it against a single point
.include SCR_CHECK_SPRITE_WEAPON
RTS
GetSelfCollisionBox:
LDA Object_x_hi,x
CLC
ADC Object_left,x
STA selfLeft
LDA Object_scroll,x
ADC #$00
STA selfNT_L
LDA Object_x_hi,x
CLC
ADC Object_right,x
STA selfRight
LDA Object_scroll,x
ADC #$00
STA selfNT_R
LDA Object_vulnerability,x
AND #%10000000
BEQ noDuckingBit
LDA Object_bottom
SEC
SBC Object_top
STA temp
LDA Object_y_hi,x
CLC
ADC temp
JMP gotSelfTop
noDuckingBit:
LDA Object_y_hi,x
CLC
ADC Object_top,x
gotSelfTop:
STA selfTop
LDA Object_y_hi,x
CLC
ADC Object_bottom,x
STA selfBottom
LDA Object_x_hi,x
CLC
ADC Object_origin_x,x
STA selfCenterX
LDA Object_y_hi,x
CLC
ADC Object_origin_y,x
STA selfCenterY
RTS
GetOtherCollisionBox:
LDA Object_x_hi,x
CLC
ADC Object_left,x
STA otherLeft
LDA Object_scroll,x
ADC #$00
STA otherNT_L
LDA Object_x_hi,x
CLC
ADC Object_right,x
STA otherRight
LDA Object_scroll,x
ADC #$00
STA otherNT_R
LDA Object_vulnerability,x
AND #%10000000
BEQ noDuckingBit_other
LDA Object_bottom
SEC
SBC Object_top
STA temp
LDA Object_y_hi,x
CLC
ADC temp
JMP gotSelfTop_other
noDuckingBit_other:
LDA Object_y_hi,x
CLC
ADC Object_top,x
gotSelfTop_other:
STA otherTop
LDA Object_y_hi,x
CLC
ADC Object_bottom,x
STA otherBottom
LDA Object_x_hi,x
CLC
ADC Object_origin_x,x
STA otherCenterX
LDA Object_y_hi,x
CLC
ADC Object_origin_y,x
STA otherCenterY
RTS
DetermineRecoilDirection:
;;;RECOIL
;;First check for the abs x value
LDA recoil_selfX
SEC
SBC recoil_otherX
BCS absCheckDone
EOR #$FF
CLC
ADC #$01
absCheckDone:
STA temp
LDA recoil_selfY
SEC
SBC recoil_otherY
BCS absCheckDone2
EOR #$FF
CLC
ADC #$01
absCheckDone2:
CMP temp
BCS vCol
LDA recoil_selfX
CMP recoil_otherX
BCS recoilRight
;; recoil left
;LDX #$01
LDA #RECOIL_SPEED_LO
STA Object_h_speed_lo,x
LDA #$00
SEC
SBC #RECOIL_SPEED_HI
STA Object_h_speed_hi,x
LDA #$00
STA Object_v_speed_hi,x
STA Object_v_speed_lo,x
LDA #%10000000
STA temp1
LDA Object_movement,x
AND #%00000111
ORA temp1
STA Object_movement,x
CPX player1_object
BNE dontChangeScrollDirectionL
LDA #$00
STA scrollDirection
dontChangeScrollDirectionL
RTS
recoilRight:
;LDX #$01
LDA #RECOIL_SPEED_LO
STA Object_h_speed_lo,x
LDA #RECOIL_SPEED_HI
STA Object_h_speed_hi,x
LDA #$00
STA Object_v_speed_hi,x
STA Object_v_speed_lo,x
LDA #%11000000
STA temp1
LDA Object_movement,x
AND #%00000111
ORA temp1
STA Object_movement,x
CPX player1_object
BNE dontChangeScrollDirectionR
LDA #$01
STA scrollDirection
dontChangeScrollDirectionR:
RTS
vCol:
LDA recoil_selfY
CMP recoil_otherY
BCS recoilDown
;LDX #$01
LDA #RECOIL_SPEED_LO
STA Object_v_speed_lo,x
LDA #$00
SEC
SBC #RECOIL_SPEED_HI
STA Object_v_speed_hi,x
LDA #%00100000
STA temp1
LDA #$00
STA Object_h_speed_hi,x
STA Object_h_speed_lo,x
LDA Object_movement,x
AND #%00000111
ORA temp1
STA Object_movement,x
RTS
recoilDown:
;LDX #$01
LDA #RECOIL_SPEED_LO
STA Object_v_speed_lo,x
LDA #RECOIL_SPEED_HI
STA Object_v_speed_hi,x
LDA #%00110000
STA temp1
LDA #$00
STA Object_h_speed_hi,x
STA Object_h_speed_lo,x
LDA Object_movement,x
AND #%00000111
ORA temp1
STA Object_movement,x
RTS